-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "raw" sizemode
to cone trace
#6938
Conversation
stackgl_modules/package.json
Outdated
@@ -13,7 +13,7 @@ | |||
"box-intersect": "plotly/box-intersect#v1.1.0", | |||
"convex-hull": "^1.0.3", | |||
"delaunay-triangulate": "^1.1.6", | |||
"gl-cone3d": "^1.5.2", | |||
"gl-cone3d": "github:gl-vis/gl-cone3d#9cf07db8d3526dbe85e9fa671857416cc3ed63e2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I tried to test it locally, but was unable to get the I think a name like "constant-absolute" makes more sense from a end-user perspective. To be honest, I assumed that "absolute" would give me what I want - ignoring the internal factor and just using the value I give. A name, or another alias that better gets that across would be great. Edit: I got the command to run by adding But, it just doesn't seem to work from python (i.e. the new "vector" option is not there). I am definitely using my local plotly version, as without |
@Sharpz7 good point - TBH I’ve forgotten the rationale behind the original two modes and their names, but if we were designing the API today, the new version would probably have been called @archmoj i haven’t played with this much, but if I’m understanding it correctly, If I have that right, I might suggest |
sizemode
to cone tracesizemode
to cone trace
Resolves #3613.
@plotly/plotly_js
demo