Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scattergl rendering when colors include capital letters #6928

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix scattergl rendering when colors include capital letters #6928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5383bf0
bump color-parse v2 fixing 6685
archmoj Mar 14, 2024
f3a9d2f
add test
archmoj Mar 14, 2024
a70265f
draft log
archmoj Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions draftlogs/6928_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix scattergl rendering when colors include capital letters [[#6928](https://github.com/plotly/plotly.js/pull/6928)],
with thanks to @28raining and @dy for the contribution!
58 changes: 45 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"canvas-fit": "^1.5.0",
"color-alpha": "1.0.4",
"color-normalize": "1.5.0",
"color-parse": "1.3.8",
"color-parse": "2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colorjs/color-parse#5

"color-rgba": "2.1.1",
"country-regex": "^1.1.0",
"d3-force": "^1.2.1",
Expand Down
Binary file added test/image/baselines/zz-gl2d-case-insenstive-colors.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
52 changes: 52 additions & 0 deletions test/image/mocks/zz-gl2d-case-insenstive-colors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"data": [
{
"type": "scatter",
"name": "svg - `RED`",
"x": [
1,
2,
3,
4
],
"y": [
10,
15,
13,
17
],
"mode": "markers",
"marker": {
"color": "RED",
"size": 12
}
},
{
"type": "scattergl",
"name": "GL - `BLUE`",
"x": [
1,
2,
3,
4
],
"y": [
9,
14,
12,
16
],
"mode": "markers",
"marker": {
"color": "BLUE",
"size": 12
}
}
],
"layout": {
"title": {
"text": "ScatterGL named-colors should be case-insensitive"
},
"showlegend": true
}
}