-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to esbuild
for faster builds and also to allow using more modern JavaScript syntax and features
#6909
Conversation
seems to work for everything except regl traces
@alexcjohnson @gvwilson |
thank you - @marthacryan can you please have a look at this as well? |
I'm looking forward to @alexcjohnson's review on this as well. Also thanks to @marthacryan and @birkskyum reviews & contributions 🙏 This PR helps unblock It might be a good idea and timing to include this in the upcoming RC release of [v2.35.0] (https://github.com/plotly/plotly.js/milestone/72) and our QA. cc: @gvwilson @ndrezn @LiamConnors It would also help our ongoing and future development and testing of other pull requests. cc: @emilykl @antoinerg |
I approve. Let's hold off on the merge until next week (feels too big to do on a Friday), but congratulations everyone - well done. |
Super excited about this! This change will really improve the development experience for Plotly.js. Kudos 🥳 |
Wonderful news 🚀 . Thank you @archmoj; Thank you @marthacryan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 I'm super excited for this. Looks great!
Thanks for the reviews! |
We'll need to configure esbuild to also allow require(file.css) because of: One option is here (esbuild-style-plugin), but there might be built-in support for this in esbuild: |
Add .css loader to esbuild
- Resolved conflicts in package-lock.json by copying lock file from master then npm install
@plotly/plotly_js
TODOs:
regl_codegen
amdefine
requirejs
kaleido
orca