Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect insiderange when multiple overlaid axes having insideticklabel #6817

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 13, 2023

@plotly_js
cc: @my-tien @stephprobst

@archmoj archmoj added bug something broken status: reviewable labels Dec 13, 2023
@archmoj archmoj requested a review from alexcjohnson December 13, 2023 19:30
@alexcjohnson
Copy link
Collaborator

I'm not sure this is quite right - if I make the labels take up a large fraction of the total area, the axis isn't expanded enough to keep the desired range off the labels (this is zz-insiderange-x-multi-y with "tickprefix": "MMMMMMM", added to layout.template.yaxis):

Screenshot 2023-12-15 at 13 11 26

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 @archmoj this PR is a big improvement as it stands now, so let’s merge it and make an issue to follow up on my comment about extreme cases later.

@archmoj
Copy link
Contributor Author

archmoj commented Feb 8, 2024

#6887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants