Merge pull request #6928 from plotly/fix6685-case-insenstive-colors-s…

…cattergl Fix `scattergl` rendering when colors include capital letters
plotly · Mar 15, 2024 · a7df816 · a7df816
2 parents c5fdc36 + a70265f
commit a7df816
Show file tree

Hide file tree

Showing 5 changed files with 100 additions and 14 deletions.
diff --git a/draftlogs/6928_fix.md b/draftlogs/6928_fix.md
@@ -0,0 +1,2 @@
+ - Fix scattergl rendering when colors include capital letters [[#6928](https://github.com/plotly/plotly.js/pull/6928)],
+   with thanks to @28raining and @dy for the contribution!
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -82,7 +82,7 @@
     "canvas-fit": "^1.5.0",
     "color-alpha": "1.0.4",
     "color-normalize": "1.5.0",
-    "color-parse": "1.3.8",
+    "color-parse": "2.0.0",
     "color-rgba": "2.1.1",
     "country-regex": "^1.1.0",
     "d3-force": "^1.2.1",

diff --git a/test/image/baselines/zz-gl2d-case-insenstive-colors.png b/test/image/baselines/zz-gl2d-case-insenstive-colors.png
diff --git a/test/image/mocks/zz-gl2d-case-insenstive-colors.json b/test/image/mocks/zz-gl2d-case-insenstive-colors.json
@@ -0,0 +1,52 @@
+{
+    "data": [
+        {
+            "type": "scatter",
+            "name": "svg - `RED`",
+            "x": [
+                1,
+                2,
+                3,
+                4
+            ],
+            "y": [
+                10,
+                15,
+                13,
+                17
+            ],
+            "mode": "markers",
+            "marker": {
+                "color": "RED",
+                "size": 12
+            }
+        },
+        {
+            "type": "scattergl",
+            "name": "GL - `BLUE`",
+            "x": [
+                1,
+                2,
+                3,
+                4
+            ],
+            "y": [
+                9,
+                14,
+                12,
+                16
+            ],
+            "mode": "markers",
+            "marker": {
+                "color": "BLUE",
+                "size": 12
+            }
+        }
+    ],
+    "layout": {
+        "title": {
+            "text": "ScatterGL named-colors should be case-insensitive"
+        },
+        "showlegend": true
+    }
+}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- Fix scattergl rendering when colors include capital letters [[#6928](https://github.com/plotly/plotly.js/pull/6928)],
		with thanks to @28raining and @dy for the contribution!