Skip to content

Commit

Permalink
Merge pull request #90 from plone/maurits-fix-html-validation
Browse files Browse the repository at this point in the history
Fix html validation
  • Loading branch information
thet committed Mar 14, 2016
2 parents 5412e89 + 250bb90 commit d5ca3a0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ Fixes:

- Fix code analysis errors reported by http://jenkins.plone.org/view/Pkgs/job/package-plonetheme.barceloneta
[gforcada]
- Drop toolbar for anonymous users.
- Fixed html validation:
- the banner role is unnecessary for element header,
- element main does not need a role attribute,
- the contentinfo role is unnecessary for element footer.
[maurits]


1.6.17 (2016-02-27)
Expand Down
6 changes: 3 additions & 3 deletions plonetheme/barceloneta/theme/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<section id="portal-toolbar">
</section>
<div class="outer-wrapper">
<header id="content-header" role="banner">
<header id="content-header">
<div class="container">
<header id="portal-top">
</header>
Expand All @@ -47,7 +47,7 @@
<div class="row">
<aside id="global_statusmessage"></aside>
</div>
<main id="main-container" class="row row-offcanvas row-offcanvas-right" role="main">
<main id="main-container" class="row row-offcanvas row-offcanvas-right">
<div id="column1-container">
</div>
<div id="content-container">
Expand All @@ -57,7 +57,7 @@
</main><!--/row-->
</div><!--/container-->
</div> <!--/outer-wrapper -->
<footer id="portal-footer-wrapper" role="contentinfo">
<footer id="portal-footer-wrapper">
<div class="container" id="portal-footer"></div>
</footer>
</body>
Expand Down
1 change: 1 addition & 0 deletions plonetheme/barceloneta/theme/rules.xml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@

<!-- toolbar -->
<replace css:theme="#portal-toolbar" css:content-children="#edit-bar" css:if-not-content=".ajax_load" css:if-content=".userrole-authenticated" />
<drop css:theme="#portal-toolbar" css:if-content=".userrole-anonymous" />
<replace css:theme="#anonymous-actions" css:content-children="#portal-personaltools-wrapper" css:if-not-content=".ajax_load" css:if-content=".userrole-anonymous" />

</rules>

0 comments on commit d5ca3a0

Please sign in to comment.