-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python3 #21
Conversation
@mister-roboto you are lying, you evil robot overlord. @dhavlik signed the CA and sent it in. |
(in behalf of mr.roboto) @pbauer no, mr.roboto is not lying! See it by yourself: https://api.github.com/repos/plone/plone.supermodel/commits/e2aa2add70c4e01e61df5acebd019461b5f796d0 https://api.github.com/repos/plone/plone.supermodel/commits/d274c5c3893af0f4e3dbf7e13ef2a7f2f88c07cb The two commits made by @dhavlik are not using any email (as mr.roboto complains) that @dhavlik has on github. That should be updated. You can clearly recognize that seeing that there is the octopus icon rather than @dhavlik avatar on the commits list: https://github.com/plone/plone.supermodel/pull/21/commits |
true and wise, oh great robot! |
@pbauer if you merge this or other pull requests adding support to python 3, would you mind creating an issue on buildout.coredev so that the py3 buildout configuration for the jenkins job gets updated as well? |
|
b78edf9
to
20ab7f7
Compare
@pbauer, @mauritsvanrees: tests pass for Python 2 but still not for 3. There's one commented line that must be removed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't really looked at this package before, so I don't feel I can really review this. I don't even know how to run the Python3 tests. Since this package has so few dependencies, a small buildout and Travis would be nice, but don't let that hinder this PR.
From a superfluous glance, the PR seems okay.
I fixed @dhavlik email address (was something with For future commits, please use the email addresses known by Github (you can add more at your profile page) |
The tests only run together with plone/plone.rfc822#4
We tried not to use six but are open to any suggestions.