Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting version for non-lowercase package adds duplicate #58

Closed
mauritsvanrees opened this issue Sep 14, 2023 · 0 comments · Fixed by #59
Closed

Setting version for non-lowercase package adds duplicate #58

mauritsvanrees opened this issue Sep 14, 2023 · 0 comments · Fixed by #59
Assignees
@mauritsvanrees

Comments

@mauritsvanrees
Copy link
Member

I release Plone and Products.CMFPlone, and then needed this fix in coredev. I seem to be missing a corner case when setting versions.

Easily testable by hand in coredev like this:

$ bin/manage set-package-version Plone 5
versions.cfg: 'Plone = 5' added.
versions-ecosystem.cfg: Plone missing.
versions-extra.cfg: Plone missing.
$ git diff
diff --git a/versions.cfg b/versions.cfg
index b2217c100..cc5510898 100644
--- a/versions.cfg
+++ b/versions.cfg
@@ -254,6 +254,7 @@ webresource = 1.2
 wrapt = 1.15.0
 wsproto = 1.2.0
 zipp = 3.16.1
+Plone = 5
@mauritsvanrees mauritsvanrees self-assigned this Sep 14, 2023
mauritsvanrees added a commit that referenced this issue Sep 14, 2023
@mauritsvanrees
Fix setting version for non-lowercase package.
b60db64 
In the previous release this would add a duplicate line.
Fixes #58
@mauritsvanrees mauritsvanrees mentioned this issue Sep 14, 2023
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Sep 14, 2023
@mauritsvanrees
[fc] Repository: plone.releaser
a7b631d 
Branch: refs/heads/master
Date: 2023-09-14T20:59:13+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@b60db64

Fix setting version for non-lowercase package.

In the previous release this would add a duplicate line.
Fixes plone/plone.releaser#58

Files changed:
A news/58.bugfix
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-14T21:35:41+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@b84d363

Merge pull request #59 from plone/maurits-issue-58-lower-case

Fix setting version for non-lowercase package.

Files changed:
A news/58.bugfix
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Sep 14, 2023
@mauritsvanrees
[fc] Repository: plone.releaser
83e7c5d 
Branch: refs/heads/master
Date: 2023-09-14T20:59:13+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@b60db64

Fix setting version for non-lowercase package.

In the previous release this would add a duplicate line.
Fixes plone/plone.releaser#58

Files changed:
A news/58.bugfix
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-14T21:35:41+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@b84d363

Merge pull request #59 from plone/maurits-issue-58-lower-case

Fix setting version for non-lowercase package.

Files changed:
A news/58.bugfix
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setting version for non-lowercase package. plone/plone.releaser
1 participant
@mauritsvanrees