repair incomplete commit from last PR (sry) #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhavlik thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
icemac
approved these changes
Aug 22, 2019
|
@jenkins-plone-org please run jobs |
icemac
requested changes
Aug 23, 2019
|
@jenkins-plone-org please run jobs |
|
@dhavlik Maybe changing the change log entry of the last PR can trick the change log verifier. |
|
@jenkins-plone-org please run jobs |
icemac
approved these changes
Aug 29, 2019
|
I have released 6.4.0 with this. |
|
@mauritsvanrees Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note to self: when using "commit suggestion" feature of github, keep in mind that there might be more than one such button.
note to self 2: thoroughly test stuff before filing a PR