Add Sentry support #124
Merged
Add Sentry support #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@jenkins-plone-org please run jobs |
|
@tschorr I have an alternative implementation here: https://github.com/collective/collective.sentry How would you log the Zope specific request information as it is present in the standard error_log? |
|
@zopyx thanks for the pointer, I didn't know about collective.sentry. As mentionned above, this PR is adding basic logging support, nothing Zope specific yet. I agree adding information from the Zope Request would be a plus. But I also think sentry configuration should go into the wsgi.ini, since this is the place were all the other logging is configured. And I like the idea of offering basic Sentry support with p.r.zope2instance. |
|
collective.sentry is less than a week old...I will check out PR. |
zopyx
approved these changes
Aug 22, 2019
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic Sentry support using the Python Sentry SDK as documented in https://docs.sentry.io/platforms/python/logging/.