Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getIcon for archetypes #61

Merged
merged 3 commits into from
Dec 3, 2015
Merged

fix: getIcon for archetypes #61

merged 3 commits into from
Dec 3, 2015

Conversation

Gagaro
Copy link
Member

@Gagaro Gagaro commented Dec 1, 2015

For plone/Products.CMFPlone#1271

⚠️ We should talk about #60 before merging! ⚠️

@jensens
Copy link
Member

jensens commented Dec 2, 2015

  1. changelog is missing (w/o no merge, so please dont forget to add it)
  2. I have no idea if we can update metadata with lesser costs.

@Gagaro Gagaro force-pushed the fix-geticon-archetypes branch from 71f51d1 to 3087285 Compare December 2, 2015 09:23
@Gagaro
Copy link
Member Author

Gagaro commented Dec 2, 2015

Changelog added.

I am currently working on a catalog with ~25,000 objects in it. Reindexing them one by one would take several hours.

If there is no other choice, maybe this step should be separated to allow the to501 to be easily done, and to allow the reindexing to be done at a later time (or to do it by hand chunk by chunk).

@jensens
Copy link
Member

jensens commented Dec 2, 2015

i changed the implementation to only deal with metadata.
May you try with your 25k items if this helps?

@jensens
Copy link
Member

jensens commented Dec 2, 2015

@Gagaro
Copy link
Member Author

Gagaro commented Dec 3, 2015

It helps a lot, it now lasts only 20 minutes.

jensens added a commit that referenced this pull request Dec 3, 2015
@jensens jensens merged commit 0c33e74 into master Dec 3, 2015
@jensens jensens deleted the fix-geticon-archetypes branch December 3, 2015 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants