Use str() when migrating checkout_workflow_policy #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested several migrations:
and found no more issues with this |
mauritsvanrees
added a commit
that referenced
this pull request
Oct 10, 2017
This mitigates the effects from #136
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Oct 11, 2017
Branch: refs/heads/master Date: 2017-10-11T01:05:00+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.upgrade@4305ce0 Fixed WrongType exception when migrating installed Iterate to 5.0. This mitigates the effects from plone/plone.app.upgrade#136 Files changed: M CHANGES.rst M plone/app/upgrade/v50/betas.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-10-11T12:19:10+02:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/plone.app.upgrade@7142a0c Merge pull request #140 from plone/iterate-both-str-unicode Fixed WrongType exception when migrating installed Iterate to 5.0. Files changed: M CHANGES.rst M plone/app/upgrade/v50/betas.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Oct 11, 2017
Branch: refs/heads/master Date: 2017-10-11T01:05:00+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.upgrade@4305ce0 Fixed WrongType exception when migrating installed Iterate to 5.0. This mitigates the effects from plone/plone.app.upgrade#136 Files changed: M CHANGES.rst M plone/app/upgrade/v50/betas.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-10-11T12:19:10+02:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/plone.app.upgrade@7142a0c Merge pull request #140 from plone/iterate-both-str-unicode Fixed WrongType exception when migrating installed Iterate to 5.0. Files changed: M CHANGES.rst M plone/app/upgrade/v50/betas.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema-field is ASCIILine since 5.1b4.
I'm not sure if this would break migrations from a existing 5.0.8 to a future 5.0.9. But it fixes migrations from Plone 4 to 5.1 provided we do not merge revert to TextLine with plone/plone.app.iterate#53
Maybe the change of plone/plone.app.iterate@a3c1340 requires another upgrade-step that changes a existing unicode-value to ascii