Merge pull request #140 from plone/djay/add_themefileupload_test

add some tests for themefileupload as these fail with current plone.rest

CHANGES.rst

@@ -14,7 +14,8 @@ New features:
 
 Bug fixes:
 
-- *add item here*
+- Added a failing (5.1) test for fileuploads in the theme editor that breaks when plone.rest is installed. Fix is in https://github.com/plone/plone.rest/issues/59
+  [djay]
 
 
 2.0.2 (2018-02-04)

src/plone/app/theming/tests/test_controlpanel.py

@@ -51,3 +51,38 @@ def test_create_theme(self):
 
     #     self.assertTrue('foobar' in [t.__name__ for t in getZODBThemes()])
     #     self.assertTrue(getTheme('foobar') is not None)
+
+
+    def test_upload_theme_file_nodata(self):
+        self.browser.addHeader('Accept', 'application/json')
+        self.browser.post(
+            self.portal.absolute_url() + '/portal_resources/themeFileUpload',
+            '',
+        )
+        self.assertIn('Status: 200', str(self.browser.headers))
+        self.assertIn(
+            '{"failure": "error"}',
+            str(self.browser.contents)
+        )
+
+    def test_upload_theme_file_withdata(self):
+        self.browser.addHeader('Accept', 'application/json')
+        self.browser.post(
+            self.portal.absolute_url() + '/portal_resources/themeFileUpload',
+            """
+---blah---
+Content-Disposition: form-data; name="file"; filename="Screen Shot 2018-02-16 at 3.08.15 pm.png"
+Content-Type: image/png
+
+
+---blah---           
+            """,
+# Bug in testbrowser prevents this working
+#            content_type='multipart/form-data; boundary=---blah---'
+
+        )
+        self.assertIn('Status: 200', str(self.browser.headers))
+        self.assertIn(
+            '{"failure": "error"}', # TODO: Should be {'success':'create'}
+            str(self.browser.contents)
+        )