Merge pull request #140 from plone/maurits-robot-tests-sleep

Tests: sleep in 'Wait For Element' and 'Wait For Then Click Element'.
plone · Aug 10, 2022 · 12a3874 · 12a3874
2 parents f37416e + 2a85987
commit 12a3874
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/news/3582.bugfix b/news/3582.bugfix
@@ -0,0 +1,4 @@
+Sleep in 'Wait For Element' and 'Wait For Then Click Element'.
+After this sleep, check that the element in question is there only once.
+Hopefully this will stabilize the Plone core robot tests.
+[maurits]
diff --git a/news/3582.feature b/news/3582.feature
@@ -0,0 +1,3 @@
+Add keyword 'Wait For Elements'.
+Here the requested element is allowed to match multiple times.
+[maurits]
diff --git a/src/plone/app/robotframework/selenium.robot b/src/plone/app/robotframework/selenium.robot
@@ -98,23 +98,40 @@ Element should become visible
 
 Wait For Element
     [Documentation]  Can contain css=, jquery=, or any other element selector.
+    ...              Element must match exactly one time.
+    [Arguments]  ${element}
+    Wait Until Page Contains Element  ${element}
+    Set Focus To Element  ${element}
+    Wait Until Element Is Visible  ${element}
+    Sleep  0.1
+    ${count} =  Get Element Count  ${element}
+    Should Be Equal as Numbers  ${count}  1
+
+Wait For Elements
+    [Documentation]  Can contain css=, jquery=, or any other element selector.
+    ...              Element may match more than once.
     [Arguments]  ${element}
     Wait Until Page Contains Element  ${element}
     Set Focus To Element  ${element}
     Wait Until Element Is Visible  ${element}
 
 Wait For Then Click Element
     [Documentation]  Can contain css=, jquery=, or any other element selector.
+    ...              Element must match exactly one time.
     [Arguments]  ${element}
     Wait For Element  ${element}
     Click Element  ${element}
 
 Wait For Then Click Invisible Element
     [Documentation]  Meant for elements that are invisible, likely because they are empty.
+    ...              Element must match exactly one time.
     ...              Can contain css=, jquery=, or any other element selector.
     [Arguments]  ${element}
     Wait Until Page Contains Element  ${element}
     Set Focus To Element  ${element}
+    Sleep  0.1
+    ${count} =  Get Element Count  ${element}
+    Should Be Equal as Numbers  ${count}  1
     Click Element  ${element}
 
 # ----------------------------------------------------------------------------