Skip to content

Commit

Permalink
Fix view @@updateLinkIntegrityInformation after Language='all' no lon…
Browse files Browse the repository at this point in the history 
…ger works
  • Loading branch information
@pbauer
pbauer committed Sep 27, 2017
1 parent 5d26542 commit 8fe0e91
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 21 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ Bug fixes:
paragraph to be always visible, even without link breaches.
[arsenico13]

- Fix view @@updateLinkIntegrityInformation after Language='all' no longer works.
[pbauer]


3.3.2 (2017-08-14)
------------------
Expand Down
21 changes: 0 additions & 21 deletions plone/app/linkintegrity/browser/update.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,6 @@
from zExceptions import NotFound

import logging
import pkg_resources


# Is there a multilingual addon?
try:
pkg_resources.get_distribution('Products.LinguaPlone')
except pkg_resources.DistributionNotFound:
HAS_MULTILINGUAL = False
else:
HAS_MULTILINGUAL = True

if not HAS_MULTILINGUAL:
try:
pkg_resources.get_distribution('plone.app.multilingual')
except pkg_resources.DistributionNotFound:
HAS_MULTILINGUAL = False
else:
HAS_MULTILINGUAL = True

logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -69,8 +50,6 @@ def update(self):
catalog = getToolByName(self.context, 'portal_catalog')
count = 0
query = {}
if HAS_MULTILINGUAL and 'Language' in catalog.indexes():
query['Language'] = 'all'

for brain in catalog(query):
try:
Expand Down

1 comment on commit 8fe0e91

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.linkintegrity/38/violations

plone/app/linkintegrity/testing.py:59:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/linkintegrity/testing.py:144:50: C812 missing trailing comma
plone/app/linkintegrity/testing.py:149:50: C812 missing trailing comma
plone/app/linkintegrity/testing.py:154:49: C812 missing trailing comma
plone/app/linkintegrity/testing.py:158:49: C812 missing trailing comma
plone/app/linkintegrity/handlers.py:30:1: C901 'findObject' is too complex (12)
plone/app/linkintegrity/handlers.py:126:5: T000 Todo note found.
plone/app/linkintegrity/utils.py:13:42: C812 missing trailing comma
plone/app/linkintegrity/utils.py:40:42: C812 missing trailing comma
plone/app/linkintegrity/upgrades.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/upgrades.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/upgrades.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/upgrades.py:7:25: Q000 Remove bad quotes.
plone/app/linkintegrity/upgrades.py:8:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/upgrades.py:9:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/upgrades.py:11:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/upgrades.py:42:5: T000 Todo note found.
plone/app/linkintegrity/upgrades.py:47:76: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:43:5: C901 'DeleteConfirmationInfo.get_breaches' is too complex (16)
plone/app/linkintegrity/browser/info.py:83:45: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:87:38: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:91:45: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:97:37: C812 missing trailing comma
plone/app/linkintegrity/browser/update.py:14:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/browser/update.py:14:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/browser/update.py:67:16: S001 found module formatter
plone/app/linkintegrity/tests/test_upgrade.py:6:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/tests/test_upgrade.py:6:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/tests/test_upgrade.py:6:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/tests/test_upgrade.py:11:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/tests/test_references.py:64:11: T000 Todo note found.
plone/app/linkintegrity/tests/test_references.py:87:23: C812 missing trailing comma
plone/app/linkintegrity/tests/test_references.py:101:23: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:59:11: T000 Todo note found.
plone/app/linkintegrity/tests/test_functional.py:149:65: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:150:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:213:59: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:214:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:296:59: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:297:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:304:34: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:308:34: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:336:65: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:337:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:342:34: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:375:65: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:376:14: C812 missing trailing comma

Follow these instructions to reproduce it locally.

Please sign in to comment.