Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the plone.navtree content provider #189

Merged
merged 2 commits into from
Mar 5, 2019

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Mar 4, 2019

Remove the plone.navtree content provider that was introduced in the context of the Navigation PLIP (plone/Products.CMFPlone#2516)
The logic has been moved to the viewlet that was invoking it.

Fixes #188

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Remove the ``plone.navtree`` content provider that was introduced in the context of the Navigation PLIP (plone/Products.CMFPlone#2516)
The logic has been moved to the viewlet that was invoking it.

Fixes #188
@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Mar 4, 2019

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member Author

ale-rt commented Mar 4, 2019

@jenkins-plone-org please run jobs

@agitator
Copy link
Member

agitator commented Mar 5, 2019

idea of the plip was to also make it possible to use the markup within a tile, therefore the content provider
no further opinion ;-)

@jensens
Copy link
Member

jensens commented Mar 5, 2019

We also can wrap viewlets in plone.app.standardtiles. This should already work b/c the viewlet name is the same as before.

@jensens jensens merged commit c4143d0 into master Mar 5, 2019
@jensens jensens deleted the 188-less-content-providers branch March 5, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants