Skip to content

Commit

Permalink
Remove plone.app.robotframework extras
Browse files Browse the repository at this point in the history 
They are not only not needed, but they would prevent the migration to Python 3.

Thanks to @datakurre for the pointers.
  • Loading branch information
@gforcada
gforcada committed Jul 13, 2017
1 parent 33b5921 commit fbddc6a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ New features:

Bug fixes:

- *add item here*
- Remove plone.app.robotframework extras (reload and ride).
They are not needed and they are not Python 3 compatible.
[gforcada]


3.0.2 (2017-07-03)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
'plone.contentrules',
'plone.app.contentrules',
'plone.app.contenttypes[test]',
'plone.app.robotframework[ride,reload]',
'plone.app.robotframework',
]
},
entry_points="""
Expand Down

1 comment on commit fbddc6a

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/32/violations

plone/app/discussion/conversation.py:334:5: D001 found adapts( replace it with zope.component.adapter
plone/app/discussion/conversation.py:415:5: D001 found adapts( replace it with zope.component.adapter
plone/app/discussion/testing.py:43:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/discussion/interfaces.py:14:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:14:1: I003 isort expected 1 blank line in imports, found 0
plone/app/discussion/interfaces.py:18:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:21:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:163:80: E501 line too long (89 > 79 characters)
plone/app/discussion/upgrades.py:63:25: S001 found module formatter
plone/app/discussion/browser/captcha.py:25:5: D001 found adapts( replace it with zope.component.adapter
plone/app/discussion/browser/captcha.py:26:15: Q000 Remove bad quotes.
plone/app/discussion/browser/captcha.py:28:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/discussion/browser/captcha.py:37:5: D001 found adapts( replace it with zope.component.adapter
plone/app/discussion/browser/captcha.py:69:1: W391 blank line at end of file
plone/app/discussion/browser/comment.py:115:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/discussion/browser/traversal.py:24:5: D001 found adapts( replace it with zope.component.adapter
plone/app/discussion/browser/validator.py:37:5: D001 found adapts( replace it with zope.component.adapter
plone/app/discussion/tests/test_events.py:8:1: I001 isort found an import in the wrong position

Follow these instructions to reproduce it locally.

Please sign in to comment.