Skip to content

Commit

Permalink
Mark edit link for translation (#91)
Browse files Browse the repository at this point in the history 
Mark edit link for translation.
  • Loading branch information
@gforcada @jensens
gforcada authored and jensens committed Apr 7, 2016
1 parent 2e3ffc9 commit eee8e3c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ New:

Fixes:

- *add item here*
- Mark 'Edit' button for translation.
https://github.com/plone/plone.app.discussion/issues/90
[gforcada]


2.4.11 (2016-03-31)
Expand Down
3 changes: 2 additions & 1 deletion plone/app/discussion/browser/comments.pt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@
so we'll use modal pattern -->
<a class="commentactionsform pat-plone-modal context"
tal:condition="auth_token"
tal:attributes="href string:${reply/absolute_url}/@@edit-comment?_authenticator=${auth_token}">Edit</a>
tal:attributes="href string:${reply/absolute_url}/@@edit-comment?_authenticator=${auth_token}"
i18n:translate="Edit">Edit</a>
<form name="edit"
action=""
method="get"
Expand Down

1 comment on commit eee8e3c

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/41/violations

plone/app/discussion/contentrules.py:20:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/conversation.py:29:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:135:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/migration.py:34:1: C901 'View.__call__' is too complex (32)

Follow these instructions to reproduce it locally.

Please sign in to comment.