migrate all tests to use dexterity, fix most tests #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I accidentally commited to master and had to revert in master. This reverts the revert.
There are currently three issues with this pull-request that will result in failing tests (at least in python3):
This fails at the moment since the ObjectAddedEvent of move-rule (test4) is triggered during
container._setObject
in_constructInstance
:When the rule is executed the container changed and the object can no longer be found in the original container.
For Archetypes the workaround was to delay the execution of the added action in
handlers.added
untilIObjectInitializedEvent
which we do not have :(See https://jenkins.plone.org/view/PLIPs/job/plip-py3/252/testReport/junit/plone.app.contentrules.tests.test_cascading_rule/TestCascadingRule/test_cascading_rule/
The sort-order of items in some tests is random. I do not know where this originates from. See https://jenkins.plone.org/view/PLIPs/job/plip-py3/252/testReport/junit/plone.app.contentrules.tests.test_configuration/TestGenericSetup/testExport/
The test
test_action_mail.testExecute
fails because of a weird issues with serialisation of text in emails. Maybe it is related to theMockMailHost
. See https://jenkins.plone.org/view/PLIPs/job/plip-py3/252/testReport/junit/plone.app.contentrules.tests.test_action_mail/TestMailAction/testExecute/