-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or replace resourceRegistries etag #93
Comments
Starting with Plone 6.0.4, the @jensens Does this make sense to you? |
I think this is an excellent idea! |
mauritsvanrees
added a commit
that referenced
this issue
Apr 25, 2023
…ation time. This time is set since Plone 6.0.4. Fixes #93. This removes the previous code which read `timestamp.txt` from `/portal_resources/resource_overrides/production`. This timestamp is no longer set in Plone 6, and does not influence anything.
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this issue
Apr 26, 2023
Branch: refs/heads/master Date: 2023-04-25T23:19:25+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.caching@57e7947 Update the resourceRegistries ETag to use the config registry modification time. This time is set since Plone 6.0.4. Fixes plone/plone.app.caching#93. This removes the previous code which read `timestamp.txt` from `/portal_resources/resource_overrides/production`. This timestamp is no longer set in Plone 6, and does not influence anything. Files changed: A news/93.feature M plone/app/caching/operations/etags.py M plone/app/caching/tests/test_profile_with_caching_proxy.py M plone/app/caching/tests/test_profile_without_caching_proxy.py Repository: plone.app.caching Branch: refs/heads/master Date: 2023-04-26T08:25:51+02:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/plone.app.caching@4cdf6fb Merge pull request #125 from plone/maurits-rr-etag Update resourceRegistries ETag to use the config registry mtime Files changed: A news/93.feature M plone/app/caching/operations/etags.py M plone/app/caching/tests/test_profile_with_caching_proxy.py M plone/app/caching/tests/test_profile_without_caching_proxy.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was initially removed in Plone 5.2 because it was for the old
portal_css/javascripts
tools. I restored it in proper form for the "new" resource registries of 5.2 in PR #65, basically reading thetimestamp.txt
. But with Plone 6 thetimestamp.txt
inportal_resources
is not there and not needed.So what do we do with this etag? Remove it? Or can it be replaced with an etag that works on Plone 6?
The point of this etag is to prevent this scenario:
If the page is cached using etags, then the job of the
resourceRegistries
etag, is to return a different value, because it sees the resource has changed.Can we come up with a sane replacement of this etag?
The text was updated successfully, but these errors were encountered: