Skip to content

Commit

Permalink
Merge pull request #27 from plone/merge-collective-indexing
Browse files Browse the repository at this point in the history 
Merge collective indexing
  • Loading branch information
@gforcada
gforcada authored Feb 21, 2017
2 parents 3c13de5 + e85355f commit efcbd7b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ Breaking changes:

New features:

- *add item here*
- Adapt tests to the new indexing operations queueing.
Part of PLIP 1343: https://github.com/plone/Products.CMFPlone/issues/1343
[gforcada]

Bug fixes:

Expand Down
7 changes: 7 additions & 0 deletions src/plone/app/blob/tests/test_maintenance.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
from Products.ATContentTypes.interface import file as atfile
from Products.ATContentTypes.interface import image as atimage

try:
from Products.CMFCore.indexing import processQueue
except ImportError:
def processQueue():
pass


class MaintenanceViewTests(ReplacementTestCase):

Expand Down Expand Up @@ -38,6 +44,7 @@ def testUpdateTypeIndex(self):
info = self.portal.portal_types.getTypeInfo('File')
info.title = 'Foo'
foo = self.folder[self.folder.invokeFactory('File', id='foo')]
processQueue()
info.title = 'File'
# make sure it's actually wrong...
catalog = self.portal.portal_catalog
Expand Down

1 comment on commit efcbd7b

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.blob/17/violations

src/plone/app/blob/iterators.py:13:9: D001 found implements( replace it with zope.interface.implementer
src/plone/app/blob/scale.py:27:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/scale.py:74:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/content.py:254:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/interfaces.py:10:37: Q000 Remove bad quotes.
src/plone/app/blob/interfaces.py:13:17: Q000 Remove bad quotes.
src/plone/app/blob/interfaces.py:14:23: Q000 Remove bad quotes.
src/plone/app/blob/monkey.py:47:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/monkey.py:53:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/monkey.py:56:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/migrations.py:43:1: C901 'makeMigrator' is too complex (15)
src/plone/app/blob/migrations.py:55:80: E501 line too long (115 > 79 characters)
src/plone/app/blob/migrations.py:83:20: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:45:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:198:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/field.py:278:16: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:343:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/field.py:360:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/field.py:387:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:390:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/download.py:35:1: C901 'handleRequestRange' is too complex (12)
src/plone/app/blob/browser/size.py:46:9: E731 do not assign a lambda expression, use a def
src/plone/app/blob/adapters/pdata.py:13:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/blobwrapper.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/atimage.py:9:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/webdav.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/file.py:11:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/xmlrpc.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/atfile.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/stringio.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/fileupload.py:17:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/ofsfile.py:11:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/tests/test_maintenance.py:6:1: I003 isort expected 1 blank line in imports, found 0
src/plone/app/blob/tests/test_replacements.py:413:9: E731 do not assign a lambda expression, use a def
src/plone/app/blob/tests/base.py:29:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/base.py:37:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/test_base_fields.py:40:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/utils.py:59:9: T001 print statement found.
src/plone/app/blob/tests/utils.py:60:9: T001 print statement found.
src/plone/app/blob/tests/utils.py:61:9: T001 print statement found.
src/plone/app/blob/tests/lingua.py:35:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/layer.py:30:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/layer.py:74:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/layer.py:109:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/subtypes/image.py:25:12: P002 found "hasattr", consider replacing it

Follow these instructions to reproduce it locally.

Please sign in to comment.