Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Cleanup and rework: contenttype-icons and ... #605

Merged
merged 4 commits into from
Nov 11, 2015
Merged

PR: Cleanup and rework: contenttype-icons and ... #605

merged 4 commits into from
Nov 11, 2015

Conversation

fgrcon
Copy link
Member

@fgrcon fgrcon commented Nov 5, 2015

@fgrcon
Copy link
Member Author

fgrcon commented Nov 9, 2015

https://travis-ci.org/plone/mockup/builds/90058035:

PhantomJS 1.9.8 (Linux 0.0.0) TinyMCE "after each" hook FAILED
TypeError: 'undefined' is not an object (evaluating 'doc.createRange') .....
✗ "after each" hook
TOTAL: 1 FAILED, 157 SUCCESS

  1. "after each" hook
    TinyMCE .....

already ocurred before my modifications

@fgrcon fgrcon closed this Nov 9, 2015
@vangheem
Copy link
Member

vangheem commented Nov 9, 2015

Why was this closed. You can ignore that error. It randomly fails all the time. We should remove the test.

Sorry, I haven't gotten around to reviewing. Is this still something you want to do?

@fgrcon
Copy link
Member Author

fgrcon commented Nov 10, 2015

@vangheem i dont know what really happened. I never intended to close that (misclick?) . Please review and see:
https://github.com/fgrcon/Products.CMFPlone/blob/master/docs/icons_in_plone5.rst for more details.

@fgrcon fgrcon reopened this Nov 10, 2015
@vangheem
Copy link
Member

@fgrcon everything looks okay. Is there a jenkins job that ran all these tests together?

@fgrcon
Copy link
Member Author

fgrcon commented Nov 11, 2015

yes: http://jenkins.plone.org/job/pull-request-5.0/539 ( s.: plone/Products.CMFPlone#1226)

vangheem added a commit that referenced this pull request Nov 11, 2015
@vangheem
Merge pull request #605 from fgrcon/master
7881c72 
PR: Cleanup and rework: contenttype-icons and ...
@vangheem vangheem merged commit 7881c72 into plone:master Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgrcon @vangheem