Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a widget for File Uploads #439

Closed
wants to merge 1 commit into from
Closed

Add a widget for File Uploads #439

wants to merge 1 commit into from

Conversation

athomerson
Copy link
Contributor

I've created a widget for file uploads that I would like to contribute. It is based on the Blueimp JQuery library. I just submitted a pull request on plone.app.widgets as well. The tests are written. I haven't written all the documentation yet.

@vangheem
Copy link
Member

Thanks! Very nice. We already have an upload pattern unfortunately and decided against using the Bluimp implementation(is what is also used in wildcard.foldercontents 1.x).

Would you be interested in contributing to the existing pattern and making it better?

@athomerson
Copy link
Contributor Author

Hi Nathan,
I saw the upload widget but I thought it was just for folder contents. Is
that the one you mean? The one I wrote is for NamedFiles but I would be
happy to contribute to the existing pattern. Why did you decide against
using the Blueimp library? I would also be happy to contribute to any other
widgets. Is there a task list somewhere?

Thanks,
Allen

On Wed, Nov 19, 2014 at 3:26 PM, Nathan Van Gheem [email protected]
wrote:

Thanks! Very nice. We already have an upload pattern unfortunately and
decided against using the Bluimp implementation(is what is also used in
wildcard.foldercontents 1.x).

Would you be interested in contributing to the existing pattern and making
it better?


Reply to this email directly or view it on GitHub
#439 (comment).

@vangheem
Copy link
Member

blueimp had a lot of dependencies.

It'd be great to make the current upload widget work with NamedFiles. It's not meant to only be for folder contents.

Oh, there is plenty to do, including bug squashing. Check out plone/Products.CMFPlone#184 in the theming and javascript section :)

@athomerson
Copy link
Contributor Author

Yeah it does have a lot of dependencies. The one that got me was a
dependency on jquery.ui even though I wasn't using the ui version.
I'll have a look at the current upload widget and see if I can figure out
how to get it to work with NamedFiles.

On Wed, Nov 19, 2014 at 3:43 PM, Nathan Van Gheem [email protected]
wrote:

blueimp had a lot of dependencies.

It'd be great to make the current upload widget work with NamedFiles. It's
not meant to only be for folder contents.

Oh, there is plenty to do, including bug squashing. Check out
plone/Products.CMFPlone#184
plone/Products.CMFPlone#184 in the theming
and javascript section :)


Reply to this email directly or view it on GitHub
#439 (comment).

@vangheem vangheem closed this Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants