Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer plone.z3cform to plone org? #139

Closed
gforcada opened this issue Nov 5, 2015 · 24 comments
Closed

Transfer plone.z3cform to plone org? #139

gforcada opened this issue Nov 5, 2015 · 24 comments

Comments

@gforcada
Copy link
Member

gforcada commented Nov 5, 2015

I just realized that plone.z3cform is not in plone github org but on zopefoundation one. Is there any reason not to move it over to plone github org?

@vincentfretin
Copy link
Member

The plone.z3cform package is in the zope foundation since the beginning under the ZPL 2.1 license. The split plone.z3cform/plone.app.z3cform was to be able to use plone.z3cform outside of the Plone community.
If you move it to the Plone foundation, I think you need to keep the license, right?

@vincentfretin
Copy link
Member

And if you move it to plone foundation, there is no sense to keep it separated from plone.app.z3cform. It should just be only one package plone.app.z3cform.

@gforcada
Copy link
Member Author

👍 I guess @esteele will be glad to merge two packages together

@gforcada
Copy link
Member Author

@esteele @polyester any reason to hold back this fork? At the least we would be able to merge the translations together :-)

@polyester
Copy link
Member

well, there's the licensing mess. The resulting merged package should come under a license, and that is messy in this case. See zopefoundation/plone.z3cform#3

To further complicate matters, it sure looks like plone.z3cform was originally under GPL, and in the Plone repository. See http://svn.plone.org/svn/plone/plone.z3cform

Relicensing it under ZPL (in 2008) was never sanctioned by the Plone Foundation (I triple checked all Foundation archives) and was therefore not legal. Since then many people have contributed, all but one (https://github.com/zopefoundation/plone.z3cform/commits?author=mgedmin) of which have signed a PF Contrib Agreement btw. Yet the commits were done while in the zopefoundation repo, apparently (although in violation of the original copyright) under ZPL.

Of course, the merged code could be relicensed by the PF under ZPL, but that feels wrong in this case; it would make BSD even more 'viral' than GPL is often accused of. Given the history of the package, I'd lean towards GPL'ing a fork/merge, but that's just my personal opinion for now.

@thet
Copy link
Member

thet commented Jun 23, 2016

you could ask @mgedmin if he is ok with relicensing or even signing the plone contributors agreement. he is still active and a reasonable guy :)

@mgedmin
Copy link

mgedmin commented Jun 27, 2016

I'm fine with ZPL as a licence, and I expect the PF contrib agreement not to be any worse than the ZF one.

(I've a commit bit for the Plone Collective, and I'm surprised that I didn't need to sign any contrib agreements for that?)

@mauritsvanrees
Copy link
Member

The Plone contributor agreement is explained and linked here:
http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

The collective is for add-ons and is open to anyone without formal checks or agreements. For the core we are more strict.

@mgedmin
Copy link

mgedmin commented Jun 29, 2016

Actually, the one and only commit I made to plone.z3cform was replacing a copy of zc.buildout's bootstrap.py with a newer copy of bootstrap.py. Do you really need a copyright assignment for that?

@jensens
Copy link
Member

jensens commented Dec 28, 2016

since the bootstrap.py has an own license this should not affect the overall licence.

@jensens
Copy link
Member

jensens commented Dec 28, 2016

So possible action (correct me if I'am wrong):

  1. Move (fork) back to /plone (we can do this anyway, its open source)
  2. assume the code is still IP of the PF (this is the question),
  3. anyway if (2) is true: since it was never activly relicensed by the IP owner to ZPL the GPL still sticks and so the code in fact is GPL!
  4. Change the README and other places to point again to PF/GPL.

mister-roboto pushed a commit that referenced this issue Oct 5, 2017
Branch: refs/heads/master
Date: 2017-10-04T17:24:33+02:00
Author: Giacomo Monari (arsenico13) <[email protected]>
Commit: plone/plone.app.content@f213926

Fixed some translations in the delete pop-over

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/delete.py
Repository: plone.app.content

Branch: refs/heads/master
Date: 2017-10-05T12:30:44+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/plone.app.content@edb44b6

Merge pull request #139 from arsenico13/fix_delete_popover_translations

Fixed some translations in the delete pop-over

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/delete.py
mister-roboto pushed a commit that referenced this issue Jan 28, 2018
Branch: refs/heads/master
Date: 2018-01-28T11:44:52+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.app.theming@107bbcb

Prepare for Python 2 / 3 compatibility

Files changed:
M CHANGES.rst
M setup.py
M src/plone/app/theming/browser/controlpanel.py
M src/plone/app/theming/browser/mapper.py
M src/plone/app/theming/plugins/utils.py
M src/plone/app/theming/tests/test_transform.py
M src/plone/app/theming/traversal.py
M src/plone/app/theming/utils.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2018-01-28T13:38:32+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.app.theming@c661a23

Merge pull request #139 from plone/python3

Prepare for Python 2 / 3 compatibility

Files changed:
M CHANGES.rst
M setup.py
M src/plone/app/theming/browser/controlpanel.py
M src/plone/app/theming/browser/mapper.py
M src/plone/app/theming/plugins/utils.py
M src/plone/app/theming/tests/test_transform.py
M src/plone/app/theming/traversal.py
M src/plone/app/theming/utils.py
mister-roboto pushed a commit that referenced this issue Jan 28, 2018
Branch: refs/heads/master
Date: 2018-01-28T11:44:52+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.app.theming@107bbcb

Prepare for Python 2 / 3 compatibility

Files changed:
M CHANGES.rst
M setup.py
M src/plone/app/theming/browser/controlpanel.py
M src/plone/app/theming/browser/mapper.py
M src/plone/app/theming/plugins/utils.py
M src/plone/app/theming/tests/test_transform.py
M src/plone/app/theming/traversal.py
M src/plone/app/theming/utils.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2018-01-28T13:38:32+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.app.theming@c661a23

Merge pull request #139 from plone/python3

Prepare for Python 2 / 3 compatibility

Files changed:
M CHANGES.rst
M setup.py
M src/plone/app/theming/browser/controlpanel.py
M src/plone/app/theming/browser/mapper.py
M src/plone/app/theming/plugins/utils.py
M src/plone/app/theming/tests/test_transform.py
M src/plone/app/theming/traversal.py
M src/plone/app/theming/utils.py
mister-roboto pushed a commit that referenced this issue Jan 29, 2018
Branch: refs/heads/master
Date: 2018-01-28T15:22:01+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.layout@d160c9b

Use `get_installer` in tests.

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/tests/test_content.py
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2018-01-29T09:55:20+01:00
Author: Jens W. Klein (jensens) <[email protected]>
Commit: plone/plone.app.layout@181ff1b

Merge pull request #139 from plone/no-qi

Use `get_installer` in tests.

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/tests/test_content.py
@petschki
Copy link
Member

petschki commented Apr 4, 2019

Hi ... since zopefoundation gets (or is already) assimilated is there a chance to get https://github.com/zopefoundation/plone.z3cform.git to /plone quick and easy? I'm willing to take care of any license changes if someone guides me. From a CI point of view this would be awesome because right now jenkins cannot run jobs with PR's from p.z3cform .... and merging p.z3cform and p.a.z3cform together seems not to be an easy task from a quick view through my omelette ...

@polyester
Copy link
Member

I'd say, given the history of the package, it should move to /plone, via the steps laid out in @jensens comment from december 2016 above, so move it and re-set GPLv2 on it.

What I'm not sure about: I can transfer the package to /plone, but I'm not sure what will all break if that happens. Should we fork or transfer?
I know people shouldn't depend on unreleased versions in production buildouts, but they may do.

So maybe it's wiser to fork/copy, and then put this one in ARCHIVE/READONLY status to make it clear it has moved.

Opinions from people wiser than me in release management?

@petschki
Copy link
Member

petschki commented Apr 4, 2019

ok let's be kind ... forking is the less offensive way doing this. So we need anyone who has rights to do so ... me not has enough 🤔 @jensens @polyester ?

Question: open PR's aren't forked, are they? If not, I'll open a new one on the forked /plone repo ... this can then be tested with jenkins ... hip hip 🎉

@mauritsvanrees
Copy link
Member

Yes, forking sounds polite.
And edit the README.rst to point to the new canonical repository.
Possibly edit the github description to have that same information. (I have no rights to do that, but you can create an issue for that.)

@tisto
Copy link
Member

tisto commented Apr 4, 2019

Forking done: https://github.com/plone/plone.z3cform

@petschki
Copy link
Member

petschki commented Apr 4, 2019

hm ... could it be that the issue tracker is not available on forks? or can it be activated?

@tisto
Copy link
Member

tisto commented Apr 4, 2019

I activated the issue tracker.

@petschki
Copy link
Member

petschki commented Apr 4, 2019

@tisto thank you ... I just wanted to create a new branch on the fork but get a permission denied? Is there something missing?

@tisto
Copy link
Member

tisto commented Apr 4, 2019

@petschki try now.

@petschki
Copy link
Member

petschki commented Apr 4, 2019

@tisto working! thank's!

@icemac
Copy link

icemac commented Apr 9, 2019

zopefoundation/plone.z3cform is now archived. Is there still anything to do or can this issue be closed now?

@petschki
Copy link
Member

petschki commented Apr 9, 2019

@icemac thank's! When my PR with license change got merged plone/plone.z3cform#2 I'll close this issue too.

@petschki
Copy link
Member

petschki commented Apr 9, 2019

done!

@petschki petschki closed this as completed Apr 9, 2019
mister-roboto pushed a commit that referenced this issue Jun 27, 2020
Branch: refs/heads/master
Date: 2020-06-26T16:01:51+02:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/plone.recipe.zope2instance@47f2b44

Fix flake8
Fixes #139

Files changed:
A news/139.bugfix
M src/plone/recipe/zope2instance/recipe.py
Repository: plone.recipe.zope2instance

Branch: refs/heads/master
Date: 2020-06-27T09:28:27+02:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/plone.recipe.zope2instance@44a4f84

Fixup

Files changed:
M src/plone/recipe/zope2instance/recipe.py
Repository: plone.recipe.zope2instance

Branch: refs/heads/master
Date: 2020-06-27T10:53:58+02:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/plone.recipe.zope2instance@d573d76

Adapt tests

Files changed:
M src/plone/recipe/zope2instance/tests/zope2instance.txt
M src/plone/recipe/zope2instance/tests/zope2instance_zserver.txt
Repository: plone.recipe.zope2instance

Branch: refs/heads/master
Date: 2020-06-27T11:46:39+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.recipe.zope2instance@d9b4c2e

Merge pull request #140 from plone/139.bugfix

Fix flake8

Files changed:
A news/139.bugfix
M src/plone/recipe/zope2instance/recipe.py
M src/plone/recipe/zope2instance/tests/zope2instance.txt
M src/plone/recipe/zope2instance/tests/zope2instance_zserver.txt
mister-roboto pushed a commit that referenced this issue Oct 5, 2020
Branch: refs/heads/master
Date: 2020-10-05T14:41:29+02:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/plone.dexterity@726bcd7

DefaultReadFile properly implements the IStreamIterator interface

Fixes #138

Files changed:
A plone/dexterity/tests/test_filerepresentation.py
M news/138.bugfix
M plone/dexterity/filerepresentation.py
M plone/dexterity/tests/case.py
M plone/dexterity/tests/test_webdav.py
Repository: plone.dexterity

Branch: refs/heads/master
Date: 2020-10-05T16:31:51+02:00
Author: Wolfgang Thomas (pysailor) <[email protected]>
Commit: plone/plone.dexterity@72915aa

Merge pull request #139 from plone/138-fixed

DefaultReadFile properly implements the IStreamIterator interface

Files changed:
A plone/dexterity/tests/test_filerepresentation.py
M news/138.bugfix
M plone/dexterity/filerepresentation.py
M plone/dexterity/tests/case.py
M plone/dexterity/tests/test_webdav.py
mister-roboto pushed a commit that referenced this issue Jan 13, 2022
Branch: refs/heads/master
Date: 2022-01-12T10:31:25+01:00
Author: Peter Mathis (petschki) <[email protected]>
Commit: plone/plone.app.z3cform@cfd79cd

Re-enable HTML rendering in form description

Files changed:
A news/138.bugfix
M plone/app/z3cform/templates/form.pt
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2022-01-13T13:01:34+01:00
Author: Laurent Lasudry (laulaz) <[email protected]>
Commit: plone/plone.app.z3cform@b9ca4b2

Merge pull request #139 from plone/issue-138

Re-enable HTML rendering in form description

Files changed:
A news/138.bugfix
M plone/app/z3cform/templates/form.pt
mister-roboto pushed a commit that referenced this issue Mar 3, 2023
Branch: refs/heads/master
Date: 2023-03-03T11:25:05+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.namedfile@eac11a7

Tox: explicitly test only the plone.namedfile package.

Otherwise tests in source checkouts may be found as well.

Files changed:
A news/50.tests
M pyproject.toml
M tox.ini
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2023-03-03T11:41:52+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.namedfile@4e7dd96

Merge pull request #139 from plone/maurits-tox-explicitly-test-only-current-package

Tox: explicitly test only the plone.namedfile package.

Files changed:
A news/50.tests
M pyproject.toml
M tox.ini
mister-roboto pushed a commit that referenced this issue Jan 30, 2024
Branch: refs/heads/main
Date: 2024-01-22T14:10:47+01:00
Author: Victor Fernandez de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@2c506a4

Add VOLTO_FRONTEND_DOMAIN as env var

Files changed:
M src/plone/volto/patches.py
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-22T14:13:31+01:00
Author: Victor Fernandez de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@2070b78

Changelog

Files changed:
A news/139.feature
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-29T12:39:18+01:00
Author: Víctor Fernández de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@ffa2651

Update src/plone/volto/patches.py

Co-authored-by: David Glick &lt;[email protected]&gt;

Files changed:
M src/plone/volto/patches.py
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-29T12:39:24+01:00
Author: Víctor Fernández de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@1ed263c

Merge branch 'main' into addfrontenddomainasenvvar

Files changed:
M CHANGES.rst
M setup.py
D news/133.bugfix
D news/137.bugfix
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-30T10:00:35-08:00
Author: David Glick (davisagli) <[email protected]>
Commit: plone/plone.volto@83c8115

Merge pull request #139 from plone/addfrontenddomainasenvvar

Add VOLTO_FRONTEND_DOMAIN as env var

Files changed:
A news/139.feature
M src/plone/volto/patches.py
mister-roboto pushed a commit that referenced this issue Jan 30, 2024
Branch: refs/heads/main
Date: 2024-01-22T14:10:47+01:00
Author: Victor Fernandez de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@2c506a4

Add VOLTO_FRONTEND_DOMAIN as env var

Files changed:
M src/plone/volto/patches.py
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-22T14:13:31+01:00
Author: Victor Fernandez de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@2070b78

Changelog

Files changed:
A news/139.feature
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-29T12:39:18+01:00
Author: Víctor Fernández de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@ffa2651

Update src/plone/volto/patches.py

Co-authored-by: David Glick &lt;[email protected]&gt;

Files changed:
M src/plone/volto/patches.py
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-29T12:39:24+01:00
Author: Víctor Fernández de Alba (sneridagh) <[email protected]>
Commit: plone/plone.volto@1ed263c

Merge branch 'main' into addfrontenddomainasenvvar

Files changed:
M CHANGES.rst
M setup.py
D news/133.bugfix
D news/137.bugfix
Repository: plone.volto

Branch: refs/heads/main
Date: 2024-01-30T10:00:35-08:00
Author: David Glick (davisagli) <[email protected]>
Commit: plone/plone.volto@83c8115

Merge pull request #139 from plone/addfrontenddomainasenvvar

Add VOLTO_FRONTEND_DOMAIN as env var

Files changed:
A news/139.feature
M src/plone/volto/patches.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants