Cleanup of PLIP #1734 #2068
Merged
Cleanup of PLIP #1734 #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fgrcon I hope you're ok with this after-PLIP cleanup. Sorry for not stepping in earlier and reviewing. Instead I did the review afterwards and fixed what I thought should be fixed myself. as your PLIP changes a lot, I thought it's worth to do it... |
|
see plone/mockup#774 (comment) and discussion above. |
|
@thet changelog please 😄 |
|
@gforcada there is already one. This PR is just a follow-up of #1734: |
ebrehault
approved these changes
Jun 14, 2017
|
tnx for approving. I'm gonna merge it to, so that these changes come ASAP into core before anyone is using the old variable names. @fgrcon if you already deployed sites based on the old var names and run into troubles, talk to me. |
thet
added a commit
to plone/mockup
that referenced
this pull request
Jun 14, 2017
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jun 14, 2017
Branch: refs/heads/master Date: 2017-06-14T15:59:38+02:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/mockup@75dfea5 adapt thumb_scale setting to changes from PR plone/Products.CMFPlone#2068 Files changed: M CHANGES.rst M mockup/patterns/structure/templates/tablerow.xml
Merged
fgrcon
added a commit
to plone/documentation
that referenced
this pull request
Jun 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #1734
To be merged together:
#2068
plone/plone.app.content#131
plone/plone.app.contenttypes#410
plone/plone.portlet.collection#17
plone/plone.app.event#258
plone/plone.app.portlets#99
plone/mockup#774