Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sendto #182

Closed
wants to merge 3 commits into from
Closed

Remove sendto #182

wants to merge 3 commits into from

Conversation

bosim
Copy link
Contributor

@bosim bosim commented Feb 18, 2014

New pull request of #179 but now with tests fixed.

@davisagli davisagli mentioned this pull request Feb 25, 2014
90 tasks
@bosim
Copy link
Contributor Author

bosim commented Mar 12, 2014

@davisagli I think this is ready for merge, I think just it needs some rebasing.. this "revert revert" is not that cool...

@davisagli
Copy link
Member

Thanks @bosim. I should be able to look at it soon.

@garbas
Copy link
Contributor

garbas commented Mar 25, 2014

should we use plone.api when we can? like sending emails? what is the policy on this?

@garbas
Copy link
Contributor

garbas commented Mar 25, 2014

this plip also introduces plone.schema as new dependency of Plone. need to look at status of it

@davisagli
Copy link
Member

plone.schema is fine to include; it's also a dependency of the editable memberdata schema PLIP. At this point it adds an Email field.

@garbas
Copy link
Contributor

garbas commented Mar 26, 2014

i guess we also dont have plone.api plip there so there we go. code looks good i'll run tests and if pass locally i'll merge it

@garbas
Copy link
Contributor

garbas commented Mar 26, 2014

rebased on master and merged manually

@garbas garbas closed this Mar 26, 2014
@bosim
Copy link
Contributor Author

bosim commented Mar 28, 2014

@garbas thanks for reviewing and merging. :)

@bosim bosim deleted the remove_sendto_cleanedup branch March 28, 2014 08:48
jensens added a commit that referenced this pull request Nov 12, 2021
Improve the new navigation and add test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants