Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last modification date button is redundant on the toolbar #999

Closed
hvelarde opened this issue Sep 16, 2015 · 14 comments
Closed

Last modification date button is redundant on the toolbar #999

hvelarde opened this issue Sep 16, 2015 · 14 comments

Comments

@hvelarde
Copy link
Member

Now that we have back in place the document_byline viewlet, the information provided by the last modification button on the toolbar became useless.

selection_004

We can remove it so we can get more space for other options.

@hvelarde hvelarde added this to the Plone 5.0 milestone Sep 16, 2015
@davisagli
Copy link
Member

Not useless. It's there because not every site will choose to keep the byline enabled.

@hvelarde
Copy link
Member Author

you can always leave the byline enabled for authenticated users and then that button is redundant; besides that, the viewlet gives you way more information than the button: you can see who created the item, when it was created and when it was modified.

@polyester
Copy link
Member

Indeed not useless. The premise behind the toolbar is:

  • whatever crazy diazo theme you decide to use, all information relevant to editors is available through the toolbar.

Now you've (succesfully) argued that the byline is dual-purpose: it can be useful to editors but also visitors. So in those cases it will indeed appear twice. Others are free to not show the viewlet; I will certainly disable it as having appear things inside the content area that look different when logged in as opposed to not-logged-in was confusing to some users.

@davilima6
Copy link
Member

I think the viewlet could come disabled by default so we don't showcase ootb a repetitive UI.

@hvelarde
Copy link
Member Author

the problem, @polyester, is the bar fails on your premise: using the toolbar I'm not able to know who created the item and when it was created (or modified); it only displays an icon (on collapsed mode) that I have to hover on to see just part of the information that was previously available:

selection_004

guys, the bar is broken in many aspects and I've been saying the obvious for months now: we decided to change a perfectly usable UI for a broken one, that's the sad true; we better fix it quickly.

@davilima6 no, we need to fix the toolbar first.

@polyester
Copy link
Member

We indeed disagree, especially if you think Plone 4 had a 'perfectly usable UI'. And you have indeed been saying the same for months, only you call it "the obvious" whereas for me it is "hvelarde's viewpoint" which is different from my viewpoint, my usecases, and my idea on how a UI should behave in a future with multiple frontends talking to the same backend; some of which may not even have 'viewlets' to enable.
Your obvious may not be other people's obvious. And yes, it is hard to please everybody all the time. And yes, there is room for evolving the toolbar.

Yet, putting back editor-info like a 'history' link into a viewlet as the only option of getting to it, is limiting everybody else's possibilities to your usecase. For me, it leads straight back in 'green bar syndrome', the mixing of two things that should not be mixed.

@hvelarde
Copy link
Member Author

I disagree, Paul; the "obvious" here is the toolbar doesn't give "all information relevant to editors"; that's not my point of view, but a fact.

the problem is we remove things all over the place without the proper care of having a working alternate solution; I've been repeating this for months and the only argument I read is: "but... but... the toolbar is so cool".

now you came with some valid points; great, that's what we needed from the beginning.

I have to get back to work now; I've spent way too much time opening issues in the previous days.

for now, I'm done.

@djay
Copy link
Member

djay commented Sep 16, 2015

+100

On Thu, 17 Sep 2015 1:49 am polyester [email protected] wrote:

We indeed disagree, especially if you think Plone 4 had a 'perfectly
usable UI'. And you have indeed been saying the same for months, only you
call it "the obvious" whereas for me it is "hvelarde's viewpoint" which is
different from my viewpoint, my usecases, and my idea on how a UI should
behave in a future with multiple frontends talking to the same backend;
some of which may not even have 'viewlets' to enable.
Your obvious may not be other people's obvious. And yes, it is hard to
please everybody all the time. And yes, there is room for evolving the
toolbar.

Yet, putting back editor-info like a 'history' link into a viewlet as the
only option of getting to it, is limiting everybody else's
possibilities to your usecase. For me, it leads straight back in 'green bar
syndrome', the mixing of two things that should not be mixed.


Reply to this email directly or view it on GitHub
#999 (comment)
.

@thet
Copy link
Member

thet commented Sep 17, 2015

I'd change the byline viewlet:

  • Remove the "History" link, because that will only be shown to users with appropriate permissions, who will have the toolbar also visible.
  • Change "last modification" to "created on", because IMO, thats more relevant for users in most use cases.
  • Use moment.js pattern on the viewlet's "created" on date.

@davisagli
Copy link
Member

Change "last modification" to "created on", because IMO, thats more relevant for users in most use cases.

Both are relevant, in my opinion.

@thet
Copy link
Member

thet commented Sep 17, 2015

I agree - depending on the usecase. Best would be to have that configurable, which one to show.

@jcerjak
Copy link
Member

jcerjak commented Sep 17, 2015

I strongly agree with @polyester - all information that is relevant to the editors should be available in the toolbar.

Reasons:

  • Versioning is a strong and very useful feature, IMHO it would be weird if it wasn't accessible from the toolbar.
  • Integrating the document_byline viewlet in the theme doesn't work for all themes
  • One place where all the editing is happening, instead of having to visually scan the page for the admin functionality (which a lot of our users found confusing in Plone < 5). We moved most of the edit functionality (including manage portlets etc.) to the toolbar, why not this?

I agree that it would be very useful to have the author info also in the toolbar. Is there room in the UI to include it, at least for expanded mode? Otherwise I think the current situation with the viewlet AND the menu entry in the toolbar is an acceptable compromise.

@hvelarde
Copy link
Member Author

I also agree with @polyester: the information should be there. But it is not; byline viewlet must be in place by default:

https://twitter.com/hvelarde/status/622045162542383104

if someone doesn't want it in a theme, can easily remove it with one Diazo line.

@polyester polyester modified the milestones: Plone 5.1, Plone 5.0 Sep 19, 2015
@hvelarde hvelarde mentioned this issue Sep 22, 2015
19 tasks
@hvelarde
Copy link
Member Author

superseded by #1560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants