Migrate Rename/Copy/Cut/Paste/Delete

[eleddy]

I'm not sure if this is addressed in the new folder listing plip or not. Please coordinate with them to see if its already re-implemented. If not, move to a utility or something. I swear @vangheem has this code already... somewhere...

Note that this is referenced from folder_contents, and that will need to be updated to reflect the new paths.

Files Rename:

• Products/CMFPlone/skins/plone_scripts/folder_rename.cpy
• Products/CMFPlone/skins/plone_scripts/object_rename.py
• Products/CMFPlone/skins/plone_scripts/folder_rename.cpy.metadata
• Products/CMFPlone/skins/plone_forms/folder_rename_form.cpt
• Products/CMFPlone/skins/plone_forms/folder_rename_form.cpt.metadata
• Products/CMFPlone/skins/plone_form_scripts/validate_folder_rename.vpy

Files Copy:

• Products/CMFPlone/skins/plone_scripts/folder_copy.cpy
• Products/CMFPlone/skins/plone_scripts/folder_copy.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_copy.cpy
• Products/CMFPlone/skins/plone_scripts/object_copy.cpy.metadata

Files Cut:

• Products/CMFPlone/skins/plone_scripts/folder_cut.cpy
• Products/CMFPlone/skins/plone_scripts/folder_cut.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_cut.cpy
• Products/CMFPlone/skins/plone_scripts/object_cut.cpy.metadata

Files Paste:

• Products/CMFPlone/skins/plone_scripts/folder_paste.cpy
• Products/CMFPlone/skins/plone_scripts/folder_paste.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_paste.cpy
• Products/CMFPlone/skins/plone_scripts/object_paste.cpy.metadata

Files Delete:

• Products/CMFPlone/skins/plone_scripts/folder_delete.cpy
• Products/CMFPlone/skins/plone_scripts/folder_delete.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_delete.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_delete.cpy

[thet]

@rnixx migrated the "cut"/"copy"/"paste"/"delete" cmf scripts to browser views here:
https://github.com/collective/bda.plone.finder/blob/master/src/bda/plone/finder/browser/actions.py#L253

this can also be the basis for rename.

[thet]

^^^ Updated Issue to cover also cut/copy/paste and delete

[eleddy]

thanks @thet

[davisagli]

@vangheem added views in plone.app.content that replace these for the purposes of the new folder contents implementation. If they aren't used elsewhere, we can remove them.

[saily]

i reviewed the code of @vangheem but there's no test at all for that code. I'm currently working on that on w&b sprint.

[davisagli]

Thanks @saily 🍺

[seanupton]

Looks like implementations for folder rename (multiple item) by @vangheem and item action by @saily take care of replacing the rename stuff previously in portal_skins.

However, I would like to contribute some kind of validation to these for the new id coming from the data. In my Plone 4.3 sites, we get users accidentally putting spaces in shortnames around twice a month accidentally via folder_rename, which causes me grief.

On that same topic, there is nothing in name chooser validating against spaces in short names / ids after portal_skins/plone_scripts/check_id goes away, which makes that problem bigger than just renaming, also for creation (I sense this should be solved by modifying plone.app.folder.base.BaseBTreeFolder._checkId?). If the _checkId() method validated against spaces, I would think that both the name chooser and the rename action(s) for one or multiple items should use it?

[jensens]

this rename problem is probably related to plone/plone.app.dexterity#73

[pbauer]

plone/plone.app.dexterity#73 is fixed in plone/plone.app.content@498634. The same still has to be done with regards to the new folder_contents