-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move language control panel to z3c.form. #218
Comments
p.a.m is for multilingual content, in case we have multilingual UI without multilingual content we sill need a language selector on control panel. As p.a.m. is going to be a core add-on we should maintain the language control panel to set the site language and its variant on p.a.controlpanel. This control panel is extended on pam, so at the moment we have it on z3cform we can adapt pam extension to use it. |
@bloodbare @sneridagh I moved the language control panel to z3c.form/p.a.registry: #251 Todo:
I guess those are good tasks for the upcoming sprints. Let me know if you need more things to get started. |
@bloodbare The language control panel is the last blocker (at least regarding the control panels) for a Plone 5 beta. Do you have time next week for a quick chat or hangout session? |
Notes from the hangout with @bloodbare:
Then @bloodbare will work on steps 2) and 3) and afterwards we will write the robot tests together. |
@bloodbare I added an additional available_languages field to the ILanguageSchema: |
…registry as discussed with @bloodbare (#218).
@bloodbare And here are the other language settings that have been moved from p.a.multilingual into CMFPlone: Your call. Let me know if there is anything I can do to help! |
@bloodbare To work with this you have to checkout the z3cform-language-controlpanel branches of both CMFPlone and plone.app.contenttypes: https://github.com/plone/Products.CMFPlone/tree/z3cform-language-controlpanel |
Content Control Settings fields are useless, so we ignore these field and don't provide them in the new control panel:
|
i think we also need a upgrade step witch reloads the profile, to setup the registry. |
@MrTango We will need such an upgrade step anyways for the other control panels. Let me know if there is anything I can do to help. The language control panel is the last big blocker for a Plone 5 beta release I guess. |
…registry as discussed with @bloodbare (#218).
…registry as discussed with @bloodbare (#218).
…registry as discussed with @bloodbare (#218).
Branch: refs/heads/master Date: 2015-03-16T11:56:20+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@532b607 Move language control panel to z3c.form/p.a.registry. Files changed: A Products/CMFPlone/controlpanel/bbb/language.py A Products/CMFPlone/controlpanel/browser/language.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_bbb_language_adapter.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py M Products/CMFPlone/controlpanel/bbb/configure.zcml M Products/CMFPlone/controlpanel/bbb/editing.py M Products/CMFPlone/controlpanel/bbb/maintenance.py M Products/CMFPlone/controlpanel/browser/configure.zcml M Products/CMFPlone/controlpanel/browser/editing.py M Products/CMFPlone/controlpanel/browser/maintenance.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_navigation.py M Products/CMFPlone/interfaces/__init__.py M Products/CMFPlone/interfaces/controlpanel.py M Products/CMFPlone/profiles/dependencies/registry.xml M Products/CMFPlone/tests/robot/keywords.robot M Products/CMFPlone/tests/robot/test_controlpanel_navigation.robot Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:20+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@cb28c9b Add robot test to set default_language in the language control panel. Files changed: A Products/CMFPlone/tests/robot/test_controlpanel_language.robot Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:20+01:00 Author: Timo Stollenwerk () <[email protected]> Commit: plone/Products.CMFPlone@b244b2d Add available_languages multi-select-field to the language control panel. Files changed: M Products/CMFPlone/interfaces/controlpanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:20+01:00 Author: Timo Stollenwerk () <[email protected]> Commit: plone/Products.CMFPlone@2145474 Move language settings from plone.app.multilingual into CMFPlone/p.a.registry as discussed with @bloodbare (plone/Products.CMFPlone#218). Files changed: M Products/CMFPlone/interfaces/controlpanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:20+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@3239fa8 add .ropeproject to gitignore Files changed: M .gitignore Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:20+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@880e16e add rest of schema and bbb fields, complete tests Files changed: M Products/CMFPlone/controlpanel/bbb/language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_bbb_language_adapter.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py M Products/CMFPlone/interfaces/controlpanel.py M Products/CMFPlone/static/plone.js M Products/CMFPlone/static/plone.less Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:20+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@009bda9 fix test_controlpanel_language Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@7833838 fix name in fieldset Files changed: M Products/CMFPlone/interfaces/controlpanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@5d9ca78 fix test_controlpanel_language.py Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@89244b4 add display_flags to language control panel Files changed: M .gitignore M Products/CMFPlone/controlpanel/bbb/language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_bbb_language_adapter.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py M Products/CMFPlone/interfaces/controlpanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@6dd5af7 fix field set for display_flags in language controlpanel Files changed: M Products/CMFPlone/interfaces/controlpanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@ef088f9 Move language control panel to z3c.form/p.a.registry. Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@5271665 add rest of schema and bbb fields, complete tests Files changed: M Products/CMFPlone/controlpanel/bbb/language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py M Products/CMFPlone/static/plone.less Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@4eaeb4a fix test_controlpanel_language Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@4974e32 fix test_controlpanel_language.py Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@48c6b4c add display_flags to language control panel Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@9f3cce8 Removing PloneLanguageTool from the setup.py Files changed: M setup.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@7719614 Remove duplication of schema and dependency on profile Files changed: M Products/CMFPlone/interfaces/controlpanel.py M Products/CMFPlone/profiles/dependencies/metadata.xml Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: MrTango (MrTango) <[email protected]> Commit: plone/Products.CMFPlone@8b8b203 pep8 fix Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@9110581 Language settings Files changed: M Products/CMFPlone/profiles/default/controlpanel.xml Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-16T11:56:21+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@70f760b Remove the LanguageTool skin and set the language on the registry on creation Files changed: M Products/CMFPlone/factory.py M Products/CMFPlone/profiles/default/skins.xml Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-17T00:22:31+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@1d00c9e Set the langauge before creating content Files changed: M Products/CMFPlone/factory.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-17T09:54:47+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@eadb810 We don't need to check for PloneLanguageTool is not there anymore Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-17T09:57:18+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@de05520 Comment out 'Scenario: Filter Navigation By Workflow States in the Navigation Control Panel'. Seems this was a work-in-progress that has been added accidentially. Files changed: M Products/CMFPlone/tests/robot/test_controlpanel_navigation.robot Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-17T09:57:18+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@9676199 Revert test_controlpanel_navigation.py change to have a cleaner pull request. Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_navigation.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-17T09:58:08+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@db76af5 PloneLanguageTool is gone. Language control panel is LanguageSettings now. Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-17T13:17:04+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@c792ebe ILanguage Interface to get content language and setting the language on portal root Files changed: A Products/CMFPlone/interfaces/language.py M Products/CMFPlone/PloneTool.py M Products/CMFPlone/factory.py M Products/CMFPlone/interfaces/__init__.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-19T11:45:56+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@6f8cd2b Always show language selector option on control panel Files changed: M Products/CMFPlone/controlpanel/bbb/language.py M Products/CMFPlone/interfaces/controlpanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-19T13:52:35+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@5c17f52 Adding always_show_selector and checking that default language is in available languages Files changed: M Products/CMFPlone/controlpanel/bbb/language.py M Products/CMFPlone/controlpanel/browser/language.py M Products/CMFPlone/interfaces/controlpanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-19T16:07:37+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@1ced7a1 We need to add an available language before setting the default language Files changed: M Products/CMFPlone/tests/robot/test_controlpanel_language.robot Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-19T16:12:04+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@eed0876 Missed PDB, just to note that this code is never used Files changed: M Products/CMFPlone/controlpanel/bbb/language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-19T16:12:29+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@19dab7a Too much things at the same time .... Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-20T09:35:40+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@3f42e8b Use a real request on the test Files changed: M Products/CMFPlone/tests/testBrowserLayerPrecedence.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-20T09:47:06+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@390e112 Tests fixing on language Files changed: M Products/CMFPlone/tests/AddMoveAndDeleteDocument.txt M Products/CMFPlone/tests/testControlPanel.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-20T16:46:10+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@d24ee68 Fix failing language control panel zope.testbrowser tests by injecting the available_languages field into the form. We have to do this because zope.testbrowser does not support js and the in-and-out widget does not work without js. Files changed: M Products/CMFPlone/controlpanel/browser/language.py M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-20T16:56:41+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@fb7d857 Fix test_default_language test. Files changed: M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-20T17:14:14+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@dea23f0 Fix failing AddMoveAndDeleteDocument doctest. Files changed: M Products/CMFPlone/tests/AddMoveAndDeleteDocument.txt Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-21T22:44:44+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@b52d750 Merge branch 'master' into z3cform-language-controlpanel Conflicts: Products/CMFPlone/tests/robot/keywords.robot Files changed: A Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_syndication.py M Products/CMFPlone/interfaces/__init__.py M Products/CMFPlone/tests/robot/keywords.robot M Products/CMFPlone/tests/robot/test_actionmenu.robot M Products/CMFPlone/tests/robot/test_controlpanel_editing.robot M Products/CMFPlone/tests/robot/test_controlpanel_filter.robot M Products/CMFPlone/tests/robot/test_controlpanel_search.robot M Products/CMFPlone/tests/robot/test_controlpanel_security.robot M Products/CMFPlone/tests/robot/test_controlpanel_site.robot M Products/CMFPlone/tests/robot/test_controlpanel_usergroups.robot M Products/CMFPlone/tests/robot/test_edit.robot M Products/CMFPlone/tests/robot/test_folder_contents.robot M Products/CMFPlone/tests/robot/test_livesearch.robot M Products/CMFPlone/tests/robot/test_overlays.robot M Products/CMFPlone/tests/robot/test_portlets.robot M Products/CMFPlone/tests/testPortalCreation.py M Products/CMFPlone/tests/testQuickInstallerTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-23T02:36:41+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@e4133ec padding instead of margin on mobile Files changed: M Products/CMFPlone/static/patterns/toolbar/src/css/toolbar.plone.less Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-23T15:50:36+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@33ee324 In case of remove language tool it calls events and there is no REQUEST on upgrade step Files changed: M Products/CMFPlone/PloneTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-25T20:19:56+01:00 Author: Timo Stollenwerk (tisto) <[email protected]> Commit: plone/Products.CMFPlone@fadaad8 Merge branch 'master' into z3cform-language-controlpanel Conflicts: Products/CMFPlone/controlpanel/bbb/configure.zcml Products/CMFPlone/interfaces/__init__.py Products/CMFPlone/interfaces/controlpanel.py Products/CMFPlone/profiles/dependencies/registry.xml Products/CMFPlone/tests/testControlPanel.py Files changed: A Products/CMFPlone/controlpanel/bbb/filter.py A Products/CMFPlone/controlpanel/browser/filter.py A Products/CMFPlone/controlpanel/browser/filter_controlpanel.pt A Products/CMFPlone/controlpanel/tests/test_controlpanel_bbb_filter_adapter.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_filter.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_usergroups_siteadmin_role.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_filter.py M CHANGES.rst M Products/CMFPlone/RegistrationTool.py M Products/CMFPlone/controlpanel/bbb/configure.zcml M Products/CMFPlone/controlpanel/browser/configure.zcml M Products/CMFPlone/interfaces/__init__.py M Products/CMFPlone/interfaces/controlpanel.py M Products/CMFPlone/profiles/default/controlpanel.xml M Products/CMFPlone/profiles/dependencies/registry.xml M Products/CMFPlone/tests/robot/test_controlpanel_filter.robot M Products/CMFPlone/tests/testControlPanel.py M Products/CMFPlone/tests/testRegistrationTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2015-03-25T21:54:09+01:00 Author: Ramon Navarro Bosch (bloodbare) <[email protected]> Commit: plone/Products.CMFPlone@f407f70 Merge pull request #251 from plone/z3cform-language-controlpanel Move language control panel to z3c.form/p.a.registry. Files changed: A Products/CMFPlone/controlpanel/bbb/language.py A Products/CMFPlone/controlpanel/browser/language.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_bbb_language_adapter.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_language.py A Products/CMFPlone/controlpanel/tests/test_controlpanel_language.py A Products/CMFPlone/interfaces/language.py A Products/CMFPlone/tests/robot/test_controlpanel_language.robot M .gitignore M Products/CMFPlone/PloneTool.py M Products/CMFPlone/controlpanel/bbb/configure.zcml M Products/CMFPlone/controlpanel/bbb/editing.py M Products/CMFPlone/controlpanel/bbb/maintenance.py M Products/CMFPlone/controlpanel/browser/configure.zcml M Products/CMFPlone/controlpanel/browser/editing.py M Products/CMFPlone/controlpanel/browser/maintenance.py M Products/CMFPlone/factory.py M Products/CMFPlone/interfaces/__init__.py M Products/CMFPlone/interfaces/controlpanel.py M Products/CMFPlone/profiles/default/controlpanel.xml M Products/CMFPlone/profiles/default/skins.xml M Products/CMFPlone/profiles/dependencies/metadata.xml M Products/CMFPlone/profiles/dependencies/registry.xml M Products/CMFPlone/static/patterns/toolbar/src/css/toolbar.plone.less M Products/CMFPlone/static/plone.js M Products/CMFPlone/tests/AddMoveAndDeleteDocument.txt M Products/CMFPlone/tests/robot/keywords.robot M Products/CMFPlone/tests/robot/test_controlpanel_navigation.robot M Products/CMFPlone/tests/testBrowserLayerPrecedence.py M Products/CMFPlone/tests/testControlPanel.py M setup.py
This has been already done in the z3c.form branch of plone.app.contenttypes:
https://github.com/plone/plone.app.controlpanel/blob/plip10359-z3cform/plone/app/controlpanel/browser/language.py
@bloodbare is this still necessary or is the language control panel already in p.a.multilingual?
The text was updated successfully, but these errors were encountered: