Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbs visibility: shown in too much listings #1322

Closed
thet opened this issue Jan 20, 2016 · 5 comments
Closed

Thumbs visibility: shown in too much listings #1322

thet opened this issue Jan 20, 2016 · 5 comments

Comments

@thet
Copy link
Member

thet commented Jan 20, 2016

There is a new setting in Site Setup, "Thumbs visibility" - defaults to "always". This settings shows image thumbnails in listings (e.g. listing_view and tabular_view), which is mostly great!
But it also shows the thumbs in the navigation portlet and possibly other portlets too. That's IMO too much.

I propose to add an option to show thumbs in portlets to each of the portlets schematas, where thumbs can be shown. The options can be the same as in Site Settings: `false,enabled``and``authenticated``.

To illustrate my problem, the following listing doesn't look nice for me:

plone-thumbs-in-listings-and-portlets

/cc @fgrcon

@zopyx
Copy link
Member

zopyx commented Jul 6, 2016

Still broken in 5.0.5

@hvelarde
Copy link
Member

hvelarde commented Jul 6, 2016

this is not an enhancement but clearly a regression from the original behavior in Plone 4.

@fgrcon
Copy link
Member

fgrcon commented Aug 8, 2016

@hvelarde: just switch off the regression in the control panel :-) ( Set Show Thumbs to Never).
@thet: you are right, more fine granular control of this would be desirable / untill that solved default should be set to NEVER ?

Im thinking about thinking about submitting a new PLIP to clean up the whole stuff:

btw: the icon story needs some cleanup as well (document type icons vs mimetype icons , attachment icon vs pdf, doc, xls ........ )

further related:
pr: plone/mockup@f068f84 (@thet where should this option be set ? right now it seems to be hardcoded in https://github.com/plone/mockup/blame/f068f8430a15f0622fe75e5b54e18bd9193c4a84/mockup/patterns/structure/pattern.js line 51 - which does not make any difference)

plone/plone.app.portlets#69
#1364

@espenmn
Copy link
Member

espenmn commented Mar 4, 2017

Even with thumb visibility off, the thumbs still show if you add a navigation portlet to the footer.

@thet
Copy link
Member Author

thet commented Aug 24, 2022

in plone 6 the listing does look nicer. see:

Screenshot from 2022-08-24 17-07-59

I'm closing this, as there is also some fine grained control possible:

  • disabling pictures to be part of the navigation
  • disabling thumbs altogether.

@thet thet closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants