Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate History Views #100

Closed
eleddy opened this issue Oct 17, 2013 · 6 comments
Closed

Migrate History Views #100

eleddy opened this issue Oct 17, 2013 · 6 comments

Comments

@giacomos
Copy link
Member

-1
it's one of the many little things that are not used on a daily base but that makes plone more sellable as it's a shimmering feature. Plus if one of our customers is really using it and asks for a migration we will end up re-adding it. It's easier to hide it than re-adding it. Please don't.

@eleddy
Copy link
Member Author

eleddy commented Oct 18, 2013

@giacomos this is going to be a problem with a lot of these features. They are great for selling but just bloat the core. This code hasn't been touched in 3 years, which is likely because its never used. IIRC, versioning isn't even enabled by default. Would you be willing to accept this ticket and move it to an add on? I feel lik it would get more love in the collective than in core, and people could update it to include more features. I know that plone has needed a general "auditing" package for a while, this could be a good start to that.

@vangheem
Copy link
Member

Code not being touched could mean it's stable. Versioning is enabled for most types by default and is an important feature of plone.

We need to keep this IMO.

@eleddy
Copy link
Member Author

eleddy commented Oct 18, 2013

@vangheem ahem, I believe just last night I was just being chastised for not removing things... ;) that's fine, we can keep it. I'll update it.

@vangheem
Copy link
Member

hey, removing arcane old cpy junk, not versioning!! You're crazy @eleddy :)

@davisagli davisagli mentioned this issue Feb 25, 2014
90 tasks
@bloodbare bloodbare modified the milestones: Plone 5.1, Plone 5 Jul 16, 2015
@jensens
Copy link
Member

jensens commented Feb 4, 2016

outdated - CMFPlone/skins/plone_forms was already removed

@jensens jensens closed this as completed Feb 4, 2016
jensens pushed a commit that referenced this issue Nov 12, 2021
…ata-for-logged-user

Do not render social metadata if you are a logged user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants