Merge pull request #3719 from plone/controlpanel-actions-modal-settings

Show `modal` property when editing an action

Products/CMFPlone/controlpanel/browser/actions.py

@@ -1,6 +1,7 @@
 from plone.autoform.form import AutoExtensibleForm
 from plone.base.interfaces import IActionSchema
 from plone.base.interfaces import INewActionSchema
+from plone.base.utils import base_hasattr
 from Products.CMFCore.ActionInformation import Action
 from Products.CMFCore.interfaces import IAction
 from Products.CMFCore.interfaces import IActionCategory
@@ -14,6 +15,8 @@
 from zope.interface import implementer
 from zope.lifecycleevent import ObjectCreatedEvent
 
+import json
+
 
 class ActionListControlPanel(BrowserView):
     """Control panel for the portal actions."""
@@ -163,6 +166,22 @@ def set_position(self, value):
 
     position = property(get_position, set_position)
 
+    def get_modal(self):
+        return self.context.modal
+
+    def set_modal(self, value):
+        # This property may not exist yet on the context.
+        if not self.context.hasProperty("modal"):
+            if base_hasattr(self.context, "modal"):
+                # We cannot define a property when an attribute with the same
+                # name already exists.
+                delattr(self.context, "modal")
+            self.context._setProperty('modal', value, 'string')
+        else:
+            self.context._setPropValue('modal', value)
+
+    modal = property(get_modal, set_modal)
+
 
 class ActionControlPanel(AutoExtensibleForm, form.EditForm):
     """A form to edit a portal action."""

news/3709.bugfix

@@ -0,0 +1,2 @@
+Fix editing `modal` property of an action in `@@actions-controlpanel`.
+[petschki]