Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access modifier to package private for RoutingDsl.{Route,RouteParam} #13003

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

WojciechMazur
Copy link
Contributor

The static private modifier for these 2 classes was incorrect. In the previous versions of Scala it compiled due to existence of a bug in the compiler.
The mentioned bug was minimized and discussed in scala/scala3#21599 and was discovered after merging a fix scala/scala3#21362
Problem was discovered by Scala 3 Open Community Build in:

Pull Request Checklist

…Param} - fixes illegal access prohibited since Scala 3.3.5 LTS and 3.6
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkurz mkurz merged commit 28447a5 into playframework:main Dec 4, 2024
29 checks passed
@mkurz
Copy link
Member

mkurz commented Dec 4, 2024

@Mergifyio backport 3.0.x 2.9.x

Copy link
Contributor

mergify bot commented Dec 4, 2024

@WojciechMazur WojciechMazur deleted the fix/routing-dsl-access branch December 4, 2024 15:01
mergify bot added a commit that referenced this pull request Dec 4, 2024
[2.9.x] Change access modifier to package private for  `RoutingDsl.{Route,RouteParam}` (backport #13003) by @WojciechMazur
mergify bot added a commit that referenced this pull request Dec 4, 2024
[3.0.x] Change access modifier to package private for  `RoutingDsl.{Route,RouteParam}` (backport #13003) by @WojciechMazur
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants