Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HikariCP instead of c3p0 connection pool #994

Closed
asolntsev opened this issue Jul 13, 2016 · 1 comment
Closed

Use HikariCP instead of c3p0 connection pool #994

asolntsev opened this issue Jul 13, 2016 · 1 comment
Assignees
@asolntsev
Labels
improvement
Milestone
1.5.0

Comments

@asolntsev
Copy link
Contributor

HikariCP is fresh and fast, while c3p0 is old and unsupported.

https://brettwooldridge.github.io/HikariCP/

To keep compatibility, we Play 1.4.x could support both c3p0 and HikariCP, so that users can configure which one they want to use. c3p0 could be the default option for the compatibility.
@asolntsev asolntsev added this to the 1.4.3 milestone Jul 13, 2016
@asolntsev asolntsev self-assigned this Jul 13, 2016
@xael-fry xael-fry modified the milestones: 1.4.4, 1.4.3 Aug 17, 2016
@xael-fry xael-fry removed this from the 1.4.4 milestone Jan 19, 2017
asolntsev added a commit to codeborne/play that referenced this issue Jun 2, 2017
@asolntsev
playframework#994 extract "/@db" part of DBPlugin to a separate class…
49fe946 
… DBBrowserPlugin

* it has a totally different responsibility, and
* it could disable itself in prod mode
asolntsev added a commit to codeborne/play that referenced this issue Jun 2, 2017
@asolntsev
playframework#994 extract c3p0-specific part of DBPlugin to a separat…
5df501c 
…e class C3P0Plugin

* it will allow user to use other implementations instead of c3p0 (for example, HikariCP)
asolntsev added a commit to codeborne/play that referenced this issue Jul 16, 2017
@asolntsev
playframework#994 extract "/@db" part of DBPlugin to a separate class…
3836c7b 
… DBBrowserPlugin

* it has a totally different responsibility, and
* it could disable itself in prod mode
asolntsev added a commit to codeborne/play that referenced this issue Jul 16, 2017
@asolntsev
playframework#994 extract c3p0-specific part of DBPlugin to a separat…
b89a2d0 
…e class C3P0Plugin

* it will allow user to use other implementations instead of c3p0 (for example, HikariCP)
@asolntsev asolntsev mentioned this issue Jul 19, 2017
Merged
asolntsev added a commit to codeborne/play that referenced this issue Jul 21, 2017
@asolntsev
playframework#994 extract "/@db" part of DBPlugin to a separate class…
d77ef4c 
… DBBrowserPlugin

* it has a totally different responsibility, and
* it could disable itself in prod mode
@xael-fry xael-fry added this to the 1.5.0 milestone Aug 1, 2017
@xael-fry
Copy link
Member

xael-fry commented Aug 1, 2017

Merged
Thanks

@xael-fry xael-fry closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asolntsev asolntsev

Labels
improvement
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@asolntsev @xael-fry