Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does play 1 support java 9? #1200

Closed
alekseysotnikov opened this issue Oct 22, 2017 · 6 comments
Closed

Does play 1 support java 9? #1200

alekseysotnikov opened this issue Oct 22, 2017 · 6 comments

Comments

@alekseysotnikov
Copy link

No description provided.

@asolntsev
Copy link
Contributor

asolntsev commented Oct 24, 2017 via email

@alekseysotnikov
Copy link
Author

Got it. No, I didn't. I just decided to ask first.

@AlexLaviolette
Copy link

It appears that Play 1 does not currently support Java 9. At the very least, ApplicationCompiler.java will need to be updated to support the new version.

@tazmaniax
Copy link
Collaborator

I'm getting the following error with continuations on Java 9 which might be related to the above point about ApplicationCompiler and/or JavaFlow...

10:26:32,015 [play-thread-1] ERROR ~ 

@75ph95fhb
Internal Server Error (500) for request GET /oauth/callback?state=2&scope=read_write&code=ac_BiBi56NS6A7gcQ7EtYgaCG1SUksAl0AB

await/Continuations error
A await/Continuations error occurred : Cannot use await/continuations when not all application classes on the callstack are properly enhanced. The following class is not enhanced: jdk.internal.reflect.NativeMethodAccessorImpl

play.exceptions.ContinuationsException: Cannot use await/continuations when not all application classes on the callstack are properly enhanced. The following class is not enhanced: jdk.internal.reflect.NativeMethodAccessorImpl
	at play.mvc.Controller.verifyContinuationsEnhancement(Controller.java:1244)
	at play.mvc.Controller.await(Controller.java:1206)
	at controllers.StripeListener.oAuthCallback(StripeListener.java:40)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at play.mvc.ActionInvoker.invokeWithContinuation(ActionInvoker.java:538)
	at play.mvc.ActionInvoker.invoke(ActionInvoker.java:475)
	at play.mvc.ActionInvoker.invokeControllerMethod(ActionInvoker.java:469)
	at play.mvc.ActionInvoker.invokeControllerMethod(ActionInvoker.java:436)
	at play.mvc.ActionInvoker.invoke(ActionInvoker.java:159)
	at Invocation.HTTP Request(Play!)

@tomparle
Copy link
Contributor

Hi,

I have the same errors on calls to await(), but apart of that, things seem to work properly.

I have this warning on application start with JDK 9, but do not know if this is related :

WARNING: Illegal reflective access by javassist.util.proxy.SecurityActions (file:/home/tom/programs/play-1.5.0/framework/lib/javassist-3.21.0-GA.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of javassist.util.proxy.SecurityActions
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations

asolntsev added a commit that referenced this issue Jul 30, 2018
fix(tests): issue #1200, added testing compatibility for jdk9+
xael-fry pushed a commit to xael-fry/play that referenced this issue Aug 23, 2018
… jdk9+

refactor(tests): issue playframework#1200, adds Controller.test class and unit test for modification on this issue

fix(tests): issue playframework#1200, fixes missing imports

fix(tests): issue playframework#1200, fixes encapsulation

fix(tests): issue playframework#1200 sorted import errors

style(tests): issue playframework#1200 beautification
xael-fry added a commit that referenced this issue Aug 23, 2018
fix(tests): issue #1200, added testing compatibility for jdk9+
@tomparle
Copy link
Contributor

Since this issue was resolved last year I think it should be closed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants