Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to load plugins from single play.plugins file #1137

Closed
asolntsev opened this issue May 9, 2017 · 1 comment
Closed

Make it possible to load plugins from single play.plugins file #1137

asolntsev opened this issue May 9, 2017 · 1 comment
Assignees
@asolntsev
Labels
has-pr
Milestone
1.5.0

Comments

@asolntsev
Copy link
Contributor

Currently Play find all play.plugins files from classpath.
It can cause several problems:

  1. There may be duplicate play.plugins files.
  2. These files may contain plugins that I don't want (for example, 450:play.db.Evolutions).
  3. It's hard to get overview of the total list and order of plugins.

As to me, it's more convenient and safe to have a single play.plugins file that contains all plugins.
@asolntsev asolntsev self-assigned this May 9, 2017
@asolntsev asolntsev added this to the 1.5.0 milestone May 9, 2017
asolntsev added a commit to codeborne/play that referenced this issue May 10, 2017
@asolntsev
playframework#1137 can load play plugins from a single descriptor
53920c0
asolntsev added a commit to codeborne/play that referenced this issue May 10, 2017
@asolntsev
playframework#1137 can load play plugins from a single descriptor
9585009
@asolntsev asolntsev mentioned this issue May 10, 2017
Merged
asolntsev added a commit to codeborne/play that referenced this issue May 10, 2017
@asolntsev
playframework#1137 can load play plugins from a single descriptor
cf0d378
@asolntsev
Copy link
Contributor Author

Implemented by #1138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asolntsev asolntsev

Labels
has-pr
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@asolntsev