Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow imported views per visit #3792

Closed

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Feb 18, 2024

Changes

This PR allows taking into account imported views per visit.

#exports-imports

Tests

  • Automated tests have been updated

Changelog

  • Entry has been added to changelog (needed?)

Documentation

  • Docs have been updated (I'll need to check if there are any mentions that it doesn't work with imported data)

Dark mode

  • The UI has been tested both in dark and light mode

@ruslandoga ruslandoga mentioned this pull request Feb 18, 2024
10 tasks
@ruslandoga ruslandoga force-pushed the allow-imported-views-per-visit branch from baa7a0d to 1ec60b2 Compare February 18, 2024 11:57
@ruslandoga ruslandoga marked this pull request as ready for review February 18, 2024 11:58
@ruslandoga ruslandoga requested a review from a team February 18, 2024 11:58
@ruslandoga ruslandoga self-assigned this Feb 18, 2024
@ruslandoga
Copy link
Contributor Author

Closing in favor of #3830

@ruslandoga ruslandoga closed this Feb 26, 2024
@ruslandoga ruslandoga deleted the allow-imported-views-per-visit branch February 26, 2024 15:32
@RobertJoonas
Copy link
Contributor

RobertJoonas commented Feb 26, 2024

Uff, sorry for this @ruslandoga. I had absolutely no intention of redoing your work 🤦🏻‍♂️ Unexpected coincidence 🙃

@ruslandoga
Copy link
Contributor Author

ruslandoga commented Feb 26, 2024

👋 @RobertJoonas

No problem! I just thought your approach was cleaner so I closed this PR :)

@ruslandoga ruslandoga removed their assignment Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants