Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim prop list to 30 items during ingestion #3009

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Trim prop list to 30 items during ingestion #3009

merged 1 commit into from
Jun 7, 2023

Conversation

vinibrsl
Copy link
Contributor

@vinibrsl vinibrsl commented Jun 6, 2023

Changes

This commit adds an upper bound limit to custom props. It fails silently and trims the list instead of dropping the event.

Documentation update PR: plausible/docs#402

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • Docs have been updated

Dark mode

  • This PR does not change the UI

This commit adds an upper bound limit to custom props. It fails silently
and trims the list instead of dropping the event.
@vinibrsl vinibrsl requested a review from a team June 6, 2023 16:46
@bundlemon
Copy link

bundlemon bot commented Jun 6, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
304.63KB -
static/js/app.js
12.31KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vinibrsl vinibrsl merged commit c559370 into master Jun 7, 2023
@vinibrsl vinibrsl deleted the trim-props branch June 7, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants