Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add landing page #2989

Merged
merged 5 commits into from
Jun 1, 2023
Merged

add landing page #2989

merged 5 commits into from
Jun 1, 2023

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented May 31, 2023 •
edited
Loading

Changes

This PR adds a landing page in dev and self-hosted setups.

That page shows up when the user is not logged in and makes a GET / request.

Screenshot 2023-05-31 at 18 14 37 Screenshot 2023-05-31 at 18 14 31 Screenshot 2023-05-31 at 18 14 06 Screenshot 2023-05-31 at 18 14 13

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@bundlemon
Copy link

bundlemon bot commented May 31, 2023 •
edited
Loading

BundleMon

Unchanged files (7)
Status Path Size Limits
✅ static/css/app.css
 492.34KB -
✅ static/js/dashboard.js
 298.84KB -
✅ static/js/app.js
 12.13KB -
✅ static/js/embed.host.js
 5.58KB -
✅ static/js/embed.content.js
 5.06KB -
✅ tracker/js/plausible.js
 742B -
✅ static/js/applyTheme.js
 314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@ruslandoga ruslandoga marked this pull request as ready for review May 31, 2023 10:14
@ukutaht ukutaht merged commit 25f95ae into master Jun 1, 2023
@ukutaht ukutaht deleted the add-landing-page branch June 1, 2023 11:34
@ruslandoga
Copy link
Contributor Author

ruslandoga commented Jun 8, 2023 •
edited
Loading

I've deployed v2.0.0-rc.2 to https://who.edify.space and realised the the twitter link is no-op... I also wonder if v2.0.0 should have registration disabled by default? #3014

@ruslandoga ruslandoga mentioned this pull request Jun 8, 2023
Merged
4 tasks
@ruslandoga
Copy link
Contributor Author

Twitter link fix: #3013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukutaht ukutaht ukutaht approved these changes

@metmarkosaric metmarkosaric Awaiting requested review from metmarkosaric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslandoga @ukutaht