-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use user-agent instead of screen_width to get device type #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: eriknakata <[email protected]>
ukutaht
changed the title
Ua device type rebase
Use user-agent instead of screen_width to get device type
Feb 28, 2023
BundleMonFiles updated (2)
Unchanged files (5)
Total files change -103B -0.01% Final result: ✅ View report in BundleMon website ➡️ |
This is just a rebased version of #2680 which was already approved by @vinibrsl. @RobertJoonas this PR also removes the browserstack config and runs the Playwright tests directly on the CI runners. I couldn't get Browserstack to work anymore :/ |
vinibrsl
approved these changes
Feb 28, 2023
aerosol
reviewed
Feb 28, 2023
aerosol
approved these changes
Feb 28, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up for #1659:
Tests
Changelog
Documentation
Dark mode