Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown bind meta #2654

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Fix unknown bind meta #2654

merged 3 commits into from
Feb 9, 2023

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Feb 7, 2023

Changes

At some point we changed which data structures are used for props and filters on the Plausible.Stats.Query struct. This PR updates some DB query building code to be aligned with the new format.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ukutaht ukutaht force-pushed the fix-unknown-bind-meta branch from 300fac0 to 3ca8168 Compare February 7, 2023 15:38
@bundlemon
Copy link

bundlemon bot commented Feb 7, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
515.18KB -
static/js/dashboard.js
298.36KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ukutaht ukutaht force-pushed the fix-unknown-bind-meta branch from 6e17a0a to 39e346d Compare February 9, 2023 13:49
@aerosol aerosol merged commit 3b73836 into master Feb 9, 2023
@aerosol aerosol deleted the fix-unknown-bind-meta branch February 9, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants