Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascade delete sent_renewal_notifications table when user is deleted #2549

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

vinibrsl
Copy link
Contributor

Changes

This pull request fixes a bug when deleting a user would trigger a database constraint error.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

This commit fixes a bug when deleting a user would trigger a constraint
error.
@vinibrsl vinibrsl requested a review from a team December 28, 2022 12:41
@bundlemon
Copy link

bundlemon bot commented Dec 28, 2022

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
515.19KB -
static/js/dashboard.js
297.95KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vinibrsl vinibrsl merged commit b6d3001 into master Jan 2, 2023
@vinibrsl vinibrsl deleted the sent-renewal-notification-cascade branch January 2, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants