Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make easier to create custom Vue component in plugin #9089

Closed
2 tasks
jardakotesovec opened this issue Jun 14, 2023 · 7 comments
Closed
2 tasks

Make easier to create custom Vue component in plugin #9089

jardakotesovec opened this issue Jun 14, 2023 · 7 comments
Assignees
Milestone

Comments

@jardakotesovec
Copy link
Contributor

jardakotesovec commented Jun 14, 2023

Its already possible to create custom vue component and than add it via smarty hooks to existing UI.

But are few small improvements to make that experience easier

  • Expose more basic components from ui-library to be global and therefore easily available to the custom component
  • Add example to the docs to see how it can be done
    Currently if plugin create custom Vue.component, its limited to the use of global components from ui-library.
@jardakotesovec
Copy link
Contributor Author

PR is now ready for review.

@jardakotesovec jardakotesovec self-assigned this Jun 29, 2023
@asmecher
Copy link
Member

asmecher commented Jul 1, 2023

No objections here, @jardakotesovec; can you open a PR against one of the applications with the specially-formulated submodule update commit message, so that the Travis tests integration can run over this change?

jardakotesovec added a commit to jardakotesovec/ojs that referenced this issue Jul 17, 2023
jardakotesovec added a commit to jardakotesovec/ojs that referenced this issue Jul 17, 2023
@jardakotesovec
Copy link
Contributor Author

@asmecher Here is the OJS PR - pkp/ojs#3977

@asmecher
Copy link
Member

Thanks, @jardakotesovec, the Travis test didn't quite complete one run but it's nothing you broke. Are you ready for #9125 to be merged and cherry-picked forward to main?

@asmecher asmecher modified the milestones: 3.4.0-x, 3.4.0-2 Jul 26, 2023
jardakotesovec added a commit that referenced this issue Jul 27, 2023
@jardakotesovec
Copy link
Contributor Author

@asmecher merged&cherry picked in pkp-lib. Should I always also update the the submodules across ojs/omp/ops?

@asmecher
Copy link
Member

Please leave the submodules for now; normally it's good practice to update submodule hashes but

  • our CI queue is already flooded, and
  • this change is very unlikely to affect the different applications differently and
  • submodule updates are likely to force other devs to need to rebase their PRS
    ...so in this case it's not warranted.

@asmecher
Copy link
Member

...and thanks for implementing this! I'll close the issue, unless there's something left to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants