Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce margins for nested lists #914

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Reduce margins for nested lists #914

merged 2 commits into from
Jan 24, 2022

Conversation

kaitlinnewson
Copy link
Member

During the upgrade guide development, it was noted that there is a lot of extra spacing in nested lists (#856). This change should reduce that, and converts the upgrade guide list back into a standard list.

Examples from https://docs.pkp.sfu.ca/accessible-content/en/principles#where-to-add-alt-text

Before change:

Screen Shot 2022-01-21 at 1 00 25 PM

After change:

Screen Shot 2022-01-21 at 1 00 36 PM

@kaitlinnewson kaitlinnewson requested a review from NateWr January 21, 2022 18:03
Copy link
Contributor

@NateWr NateWr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of suggestions. Have you had a quick look at other lists in the docs, just to check that there isn't a negative impact there? Probably fine.

_sass/components/book.scss Outdated Show resolved Hide resolved
_sass/components/book.scss Outdated Show resolved Hide resolved
@kaitlinnewson
Copy link
Member Author

Thanks @NateWr, I've incorporated your suggested changes. I have looked across some of the other guides as well where I could find nested lists and haven't noticed any issues (Learning OJS, the Admin guide, the Accessibility guide, the main dev docs, and the Contributors guide).

@kaitlinnewson kaitlinnewson merged commit 6cf72ad into main Jan 24, 2022
@kaitlinnewson kaitlinnewson deleted the list-style branch January 24, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants