POC: Simpler database auto-closure using using keyword
#6791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
using keywordusing keyword
This was referenced Nov 1, 2023
fregante
force-pushed
the
F/dev/using-typescript-key
branch
from
3ce48bd to
22a3e8d
Compare
|
ESLint won't support this until it's in Stage 4, which may happen much later unless we swap the parser.
Closing for now |
twschiller
reviewed
Nov 1, 2023
src/telemetry/logging.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Add a log entry to the database. | ||
| * @param entry the log entry to add | ||
| */ | ||
| export async function appendEntry(entry: LogEntry): Promise<void> { | ||
| const db = await getDB(); | ||
| const {db} = await using getDB(); |
There was a problem hiding this comment.
I think the "using" goes where the const is?
There was a problem hiding this comment.
You're right. It turns out that immediate destructuring isn't possible either so it would look like this:
using resource = await getDB();
resource.db.getAll();I pushed a new partial commit here just for reference
There was a problem hiding this comment.
Opened in issue in the Typescript IDB repository: jakearchibald/idb#300
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reviewer Tips
A few dependency updates are needed before this can be merged:
usingkeyword is not supported eslint/eslint#17701Checklist