Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy errors in lab.py #194

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Fix mypy errors in lab.py #194

merged 1 commit into from
Aug 25, 2024

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Aug 11, 2024

Run mypy with --strict flag and fix errors in lab.py due to a missing type hint

Contributes to #45 by fixing existing type hint errors prior to introducing mypy to the repo.

Before:

> mypy --strict pittapi/lab.py 
pittapi/lab.py:55: error: Function is missing a type annotation  [no-untyped-def]
pittapi/lab.py:84: error: Call to untyped function "LabAPIError" in typed context  [no-untyped-call]
pittapi/lab.py:86: error: Call to untyped function "LabAPIError" in typed context  [no-untyped-call]
Found 3 errors in 1 file (checked 1 source file)

After:

> mypy --strict pittapi/lab.py
Success: no issues found in 1 source file

@tianyizheng02 tianyizheng02 changed the title Add type hint to fix mypy errors in lab.py Fix mypy errors in lab.py Aug 11, 2024
@tianyizheng02 tianyizheng02 merged commit 58a08c6 into dev Aug 25, 2024
4 checks passed
@tianyizheng02 tianyizheng02 deleted the mypy-lab branch August 25, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants