Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI option --stdin-path to provide a virtual file location for stdin #2836

Merged
merged 5 commits into from
Oct 19, 2024

Conversation

adecker89
Copy link
Contributor

@adecker89 adecker89 commented Oct 16, 2024

Description

Fixes #1123

Add an optional CLI --stdin-path to provide a virtual file location for stdin. This allows for re-enabling the FilenameRule as well as supporting custom rules that rely on the file path while still using stdin.

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@paul-dingemans
Copy link
Collaborator

Tnx for your contribution. I have made some fixes as that was easier compared to provide feedback review. Most important is that you (accidentally) introduced a breaking API change.

@paul-dingemans paul-dingemans added this to the 1.4.0 milestone Oct 19, 2024
@paul-dingemans paul-dingemans merged commit 80c4d5d into pinterest:master Oct 19, 2024
20 checks passed
@paul-dingemans paul-dingemans changed the title Fixes #1123 - Add --stdin-path to provide a virtual file location for stdin Add CLI option --stdin-path to provide a virtual file location for stdin Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing a file path when using --stdin
2 participants