Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle trailing space on preceding line in call to lineLengthWithoutNewlinePrefix #2644

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Apr 23, 2024

Description

If first line in code below ends with a trailing space, an exception was thrown when calling method lineLengthWithoutNewlinePrefix for a node on line 2:

val foo1 = "foo1"
val foo2 = "foo2"

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@paul-dingemans paul-dingemans added this to the 1.3.0 milestone Apr 23, 2024
@paul-dingemans paul-dingemans merged commit 1d41320 into master Apr 27, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the bug-lineLengthWithoutNewlinePrefix branch April 27, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant