Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/checkout action to v4 #2225

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 4, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/checkout action major v3 -> v4

Release Notes

actions/checkout (actions/checkout)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
if: github.repository == 'pinterest/ktlint'
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can replace these hash strings with v4, instead of annoying updates by Renovate.

@paul-dingemans

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Github best practices, the safest approach is to use the SHA commit id instead of version tags. See https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but the following updates will be a little frequent.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I wil see what happens. If it annoys me too much, I can always remove the SHA's and fallback to the version numbers.

@paul-dingemans paul-dingemans merged commit d6b37c2 into master Oct 8, 2023
@paul-dingemans paul-dingemans deleted the renovate/actions-checkout-4.x branch October 8, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants