planner: refactor some code of binding cache #58504
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| } | ||
|
|
||
| useBinding := enableUseBinding && isStmtNode && match | ||
| if sessVars.StmtCtx.EnableOptimizerDebugTrace { |
There was a problem hiding this comment.
Remove to keep the code simple since no one is using OptimizerDebugTrace.
|
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58504 +/- ##
================================================
+ Coverage 73.5387% 74.8944% +1.3556%
================================================
Files 1681 1726 +45
Lines 464263 472548 +8285
================================================
+ Hits 341413 353912 +12499
+ Misses 102025 96351 -5674
- Partials 20825 22285 +1460
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, lance6716, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: ref #51347
Problem Summary: planner: refactor some code of binding cache
What changed and how does it work?
planner: refactor some code of binding cache
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.